Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643165

Re: [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy

Show all headers | View raw

On Tue, May 16, 2017 at 09:01:27AM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@armlinux.org.uk> [170503 11:58]:
> > On Mon, Apr 10, 2017 at 09:52:47AM -0500, Dave Gerlach wrote:
> > > Currently the sram-exec functionality, which allows allocation of
> > > executable memory and provides an API to move code to it, is only
> > > selected in configs for the ARM architecture. Based on commit
> > > 5756e9dd0de6 ("ARM: 6640/1: Thumb-2: Symbol manipulation macros for
> > > function body copying") simply copying a C function pointer address
> > > using memcpy without consideration of alignment and Thumb is unsafe on
> > > ARM platforms.
> > > 
> > > The aforementioned patch introduces the fncpy macro which is a safe way
> > > to copy executable code on ARM platforms, so let's make use of that here
> > > rather than the unsafe plain memcpy that was previously used by
> > > sram_exec_copy. Now sram_exec_copy will move the code to "dst" and
> > > return an address that is guaranteed to be safely callable.
> > > 
> > > In the future, architectures hoping to make use of the sram-exec
> > > functionality must define an fncpy macro just as ARM has done to
> > > guarantee or check for safe copying to executable memory before allowing
> > > the arch to select CONFIG_SRAM_EXEC.
> > > 
> > > Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> > 
> > Looks a lot saner, thanks.  It's just a bit sad that we lose the type
> > checking.
> > 
> > Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Looks like this is still pending so I'll add it into
> omap-for-v4.12/fixes so we can get this out of the way.

It's a "fix"?  Looked to be a 4.13 issue, sorry for the delay, otherwise
I would have queued it up earlier.

No objection for you to take this through your tree.

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy Tony Lindgren <tony@atomide.com> - 2017-05-16 18:10 +0200
  Re: [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-17 11:20 +0200
    Re: [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-17 13:50 +0200
      Re: [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy Tony Lindgren <tony@atomide.com> - 2017-05-17 15:50 +0200
        Re: [PATCH v2] misc: sram-exec: Use aligned fncpy instead of memcpy Dave Gerlach <d-gerlach@ti.com> - 2017-05-17 16:30 +0200

csiph-web