Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643140

[PATCH 6/6] ubifs: Remove dead code from ubifs_get_link()

Show all headers | View raw

We check the length already, no need to check later
again for an empty string.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 fs/ubifs/file.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 2cda3d67e2d0..ccb7a1279fd5 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -1698,12 +1698,6 @@ static const char *ubifs_get_link(struct dentry *dentry,
 
 	pstr.name[pstr.len] = '\0';
 
-	// XXX this probably won't happen anymore...
-	if (pstr.name[0] == '\0') {
-		fscrypt_fname_free_buffer(&pstr);
-		return ERR_PTR(-ENOENT);
-	}
-
 	set_delayed_call(done, kfree_link, pstr.name);
 	return pstr.name;
 }
-- 
2.12.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] ubifs: Don't try to encrypt special files Richard Weinberger <richard@nod.at> - 2017-05-17 10:40 +0200
  [PATCH 2/6] ubifs: Fix data node size for truncating uncompressed nodes Richard Weinberger <richard@nod.at> - 2017-05-17 10:40 +0200
  [PATCH 6/6] ubifs: Remove dead code from ubifs_get_link() Richard Weinberger <richard@nod.at> - 2017-05-17 10:40 +0200
  [PATCH 3/6] ubifs: Fix unlink code wrt. double hash lookups Richard Weinberger <richard@nod.at> - 2017-05-17 10:50 +0200

csiph-web