Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641997

[PATCH 6/6] PNP: Delete an error message for a failed memory allocation in quirk_awe32_add_ports()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 6/6] PNP: Delete an error message for a failed memory allocation in quirk_awe32_add_ports()
Date 2017-05-15 21:30 +0200
Message-ID <tHtQR-3NK-7@gated-at.bofh.it> (permalink)
References <tHtHb-3KQ-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 May 2017 20:36:35 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pnp/quirks.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index f9be5f3fb7ea..ae7fbf105e0a 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -33,8 +33,5 @@ static void quirk_awe32_add_ports(struct pnp_dev *dev,
-	if (!new_option) {
-		dev_err(&dev->dev, "couldn't add ioport region to option set "
-			"%d\n", pnp_option_set(option));
+	if (!new_option)
 		return;
-	}
 
 	*new_option = *option;
 	new_option->u.port.min += offset;
-- 
2.13.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] PNP: Adjustments for four function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-15 21:20 +0200
  [PATCH 6/6] PNP: Delete an error message for a failed memory  allocation in quirk_awe32_add_ports() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-15 21:30 +0200
  [PATCH 5/6] PNP: Improve a size determination in  quirk_awe32_add_ports() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-15 21:30 +0200

csiph-web