Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641736

Re: [PATCH] sched: remove sched_find_first_bit()

Show all headers | View raw

On Sat, May 13, 2017 at 3:01 AM, Yury Norov <ynorov@caviumnetworks.com> wrote:

> include/asm-generic/bitops/sched.h as it declares only this
> function.  Alpha has it's own implementation, very similar to
> generic one, so it is also removed.

Nice consolidation, I see that every architecture once had a copy of
this function, and they were all removed at one point long ago,
except for Alpha, and there is no reason to leave that one in the tree.

I'll leave it to you and Ingo to figure out what the two callers should
do, but for removing function from asm-generic:

Acked-by: Arnd Bergmann <arnd@arndb.de>

Maybe you could split the patch into two changesets, and make the
first of them move the function to kernel/sched/rt.c, and the second
one (if we still want it then) can change the implementation to whatever
you conclude is ideal.

      Arnd

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] sched: remove sched_find_first_bit() Arnd Bergmann <arnd@arndb.de> - 2017-05-15 16:20 +0200

csiph-web