Re: [PATCH] devicetree: Move include prefixes from arch to separate directory

From	Rob Herring <robh+dt@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] devicetree: Move include prefixes from arch to separate directory
Date	2017-05-15 15:10 +0200
Message-ID	<tHnV8-cB-29@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 12, 2017 at 10:34 PM, Olof Johansson <olof@lixom.net> wrote:
> We use a directory under arch/$ARCH/boot/dts as an include path
> that has links outside of the subtree to find dt-bindings from under
> include/dt-bindings. That's been working well, but new DT architectures
> haven't been adding them by default.
>
> Recently there's been a desire to share some of the DT material between
> arm and arm64, which originally caused developers to create symlinks or
> relative includes between the subtrees. This isn't ideal -- it breaks
> if the DT files aren't stored in the exact same hierarchy as the kernel
> tree, and generally it's just icky.
>
> As a somewhat cleaner solution we decided to add a $ARCH/ prefix link
> once, and allow DTS files to reference dtsi (and dts) files in other
> architectures that way.
>
> Original approach was to create these links under each architecture,
> but it lead to the problem of recursive symlinks.
>
> As a remedy, move the include link directories out of the architecture
> trees into a common location. At the same time, they can now share one
> directory and one dt-bindings/ link as well.
>
> Fixes: 4027494ae6e3 ('ARM: dts: add arm/arm64 include symlinks')
> Reported-by: Russell King <linux@armlinux.org.uk>
> Reported-by: Omar Sandoval <osandov@osandov.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Mikael Starvik <starvik@axis.com>
> Cc: Jesper Nilsson <jesper.nilsson@axis.com>
> Cc: James Hogan <james.hogan@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: linux-arch <linux-arch@vger.kernel.org>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>  arch/arm/boot/dts/include/arm             | 1 -
>  arch/arm/boot/dts/include/arm64           | 1 -
>  arch/arm/boot/dts/include/dt-bindings     | 1 -
>  arch/arm64/boot/dts/include/arm           | 1 -
>  arch/arm64/boot/dts/include/arm64         | 1 -
>  arch/arm64/boot/dts/include/dt-bindings   | 1 -
>  arch/cris/boot/dts/include/dt-bindings    | 1 -
>  arch/metag/boot/dts/include/dt-bindings   | 1 -
>  arch/mips/boot/dts/include/dt-bindings    | 1 -
>  arch/powerpc/boot/dts/include/dt-bindings | 1 -
>  scripts/Makefile.lib                      | 2 +-
>  scripts/dtc/include-prefixes/arc          | 1 +
>  scripts/dtc/include-prefixes/arm          | 1 +
>  scripts/dtc/include-prefixes/arm64        | 1 +
>  scripts/dtc/include-prefixes/c6x          | 1 +
>  scripts/dtc/include-prefixes/cris         | 1 +
>  scripts/dtc/include-prefixes/dt-bindings  | 1 +
>  scripts/dtc/include-prefixes/h8300        | 1 +
>  scripts/dtc/include-prefixes/metag        | 1 +
>  scripts/dtc/include-prefixes/microblaze   | 1 +
>  scripts/dtc/include-prefixes/mips         | 1 +
>  scripts/dtc/include-prefixes/nios2        | 1 +
>  scripts/dtc/include-prefixes/openrisc     | 1 +
>  scripts/dtc/include-prefixes/powerpc      | 1 +
>  scripts/dtc/include-prefixes/sh           | 1 +
>  scripts/dtc/include-prefixes/xtensa       | 1 +

I'd prefer not to mix things in scripts/dtc that aren't the import of
dtc (yes, we do have a few other things already, but they are at least
scripts). Couldn't this go in include/dt-bindings/ instead?

Rob

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Rob Herring <robh+dt@kernel.org> - 2017-05-15 15:10 +0200
  Re: [PATCH] devicetree: Move include prefixes from arch to separate  directory Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-15 16:30 +0200
    Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Rob Herring <robh+dt@kernel.org> - 2017-05-15 16:50 +0200
      Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Olof Johansson <olof@lixom.net> - 2017-05-15 17:30 +0200
        Re: [PATCH] devicetree: Move include prefixes from arch to separate  directory Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-15 17:50 +0200
          Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Olof Johansson <olof@lixom.net> - 2017-05-15 19:10 +0200
            Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-17 16:00 +0200
        Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Rob Herring <robh+dt@kernel.org> - 2017-05-15 18:00 +0200
          Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Olof Johansson <olof@lixom.net> - 2017-05-15 18:10 +0200
            Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Rob Herring <robh+dt@kernel.org> - 2017-05-15 18:50 +0200
            Re: [PATCH] devicetree: Move include prefixes from arch to separate directory Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-17 16:30 +0200
      Re: [PATCH] devicetree: Move include prefixes from arch to separate  directory Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-15 17:30 +0200

csiph-web