Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641553

Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems
Date Mon, 15 May 2017 13:20:02 +0200
Message-ID <tHmcG-7ob-11@gated-at.bofh.it> (permalink)
References <tHm2Z-7kX-9@gated-at.bofh.it> <tHm2Z-7kX-7@gated-at.bofh.it>
X-Original-To Mika Westerberg <mika.westerberg@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, Jean Delvare <jdelvare@suse.com>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.38,344,1491289200"; d="scan'208";a="1169331804"
Organization Intel Finland Oy
Content-Type text/plain; charset="UTF-8"
X-Mailer Evolution 3.22.6-1
MIME-Version 1.0
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
X-Original-Cc Heikki Krogerus <heikki.krogerus@linux.intel.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Wei Yongjun <weiyongjun1@huawei.com>, bbaude@redhat.com, mildred-bug.kernel@mildred.fr, barnacs@justletit.be, lvuksta@gmail.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
X-Original-Date Mon, 15 May 2017 14:14:38 +0300
X-Original-Message-ID <1494846878.6967.58.camel@linux.intel.com>
X-Original-References <20170515110103.59765-1-mika.westerberg@linux.intel.com> <20170515110103.59765-4-mika.westerberg@linux.intel.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1641553

Show key headers only | View raw


On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote:
> It turns out there are quite many Chromebooks out there that have the
> same keyboard issue than Acer Chromebook. All of them are based on
> Intel_Strago reference and report their DMI_PRODUCT_FAMILY as
> "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are
> exceptions
> for which we add separate entries).
> 
> Instead of adding each machine to the quirk table, we use
> DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the
> machines out there currently.
> 
> 

> +		.ident = "Intel_Strago based Chromebooks",

> +		.ident = "Cyan Chromebook",

> +		.ident = "Samsung Chromebook 3",

I would do something like below (though I'm fine with current as well).

	.ident = "Intel_Strago based Chromebooks (All models)",
	.ident = "Intel_Strago based Chromebooks (Cyan)",
	.ident = "Samsung Chromebook 3 (Celes)",

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-15 13:10 +0200
  Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI  quirk to Intel_Strago systems Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-15 13:20 +0200
    Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk  to Intel_Strago systems Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-15 13:20 +0200
    Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk  to Intel_Strago systems Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-16 00:30 +0200

csiph-web