Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641518

Re: [PATCH 4/9] staging: sm750fb: removing unnecessary binary operations

Show all headers | View raw

On Sun, May 14, 2017 at 12:42:37AM +0200, Matej Dujava wrote:
> This patch remove unnecessary operation (eg. ``X | (0x0 << Y)`` to ``X``).
> 
> Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
> ---
>  drivers/staging/sm750fb/ddk750_display.h | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
> index cef7f46..f9e1614 100644
> --- a/drivers/staging/sm750fb/ddk750_display.h
> +++ b/drivers/staging/sm750fb/ddk750_display.h
> @@ -9,8 +9,8 @@
>  #define PNL_2_OFFSET	0
>  #define PNL_2_MASK	(3 << PNL_2_OFFSET)
>  #define PNL_2_USAGE	(PNL_2_MASK << 16)
> -#define PNL_2_PRI	((0 << PNL_2_OFFSET) | PNL_2_USAGE)
> -#define PNL_2_SEC	((2 << PNL_2_OFFSET) | PNL_2_USAGE)
> +#define PNL_2_PRI	(PNL_2_USAGE)
> +#define PNL_2_SEC	(PNL_2_USAGE | (2 << PNL_2_OFFSET))

But the original makes more sense to read, don't you think so?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] staging: sm750fb: cleaning code Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
  [PATCH 1/9] staging: sm750fb: fix length of lines Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
    Re: [PATCH 1/9] staging: sm750fb: fix length of lines Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-15 10:40 +0200
  [PATCH 8/9] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
  [PATCH 2/9] staging: sm750fb: unifying macro definitions Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
  [PATCH 3/9] staging: sm750fb: reordering of macro definitions Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
    Re: [PATCH 3/9] staging: sm750fb: reordering of macro definitions Greg KH <greg@kroah.com> - 2017-05-15 12:30 +0200
  [PATCH 9/9] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t" Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
  [PATCH 7/9] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
  [PATCH 4/9] staging: sm750fb: removing unnecessary binary operations Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
    Re: [PATCH 4/9] staging: sm750fb: removing unnecessary binary  operations Greg KH <greg@kroah.com> - 2017-05-15 12:30 +0200
  [PATCH 6/9] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t" Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-14 00:50 +0200
  Re: [PATCH 0/9] staging: sm750fb: cleaning code Greg KH <greg@kroah.com> - 2017-05-15 12:30 +0200
  [PATCH v2 0/7] staging: sm750fb: cleaning code Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 00:00 +0200
    [PATCH v2 3/7] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t" Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 00:00 +0200
    [PATCH v2 5/7] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 00:00 +0200
    [PATCH v2 2/7] staging: sm750fb: unifying macro usage and definitions Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 00:00 +0200
    [PATCH v2 1/7] staging: sm750fb: fix length of lines, function calls and declaration Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 00:00 +0200
    [PATCH v3 0/7] staging: sm750fb: cleaning code Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 11:30 +0200
      [PATCH v3 6/7] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 11:30 +0200
      [PATCH v3 1/7] staging: sm750fb: fix length of lines, function calls and declaration Matej Dujava <mdujava@kocurkovo.cz> - 2017-05-16 11:30 +0200
      Re: [PATCH v3 0/7] staging: sm750fb: cleaning code Greg KH <gregkh@linuxfoundation.org> - 2017-05-16 13:40 +0200

csiph-web