Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1641472
| From | Sebastian Reichel <sebastian.reichel@collabora.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCHv3 07/14] pinctrl: mcp23s08: use managed kzalloc for mcp |
| Date | 2017-05-15 11:30 +0200 |
| Message-ID | <tHkuf-6eH-31@gated-at.bofh.it> (permalink) |
| References | <tHkud-6eH-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Let's remove a few lines of code by using managed memory for mcp variable. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> --- drivers/pinctrl/pinctrl-mcp23s08.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index 94d2c19a6989..4d2e1c3c0e87 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -1019,7 +1019,7 @@ static int mcp230xx_probe(struct i2c_client *client, } } - mcp = kzalloc(sizeof(*mcp), GFP_KERNEL); + mcp = devm_kzalloc(&client->dev, sizeof(*mcp), GFP_KERNEL); if (!mcp) return -ENOMEM; @@ -1027,16 +1027,11 @@ static int mcp230xx_probe(struct i2c_client *client, status = mcp23s08_probe_one(mcp, &client->dev, client, client->addr, id->driver_data, pdata, 0); if (status) - goto fail; + return status; i2c_set_clientdata(client, mcp); return 0; - -fail: - kfree(mcp); - - return status; } static int mcp230xx_remove(struct i2c_client *client) @@ -1044,7 +1039,6 @@ static int mcp230xx_remove(struct i2c_client *client) struct mcp23s08 *mcp = i2c_get_clientdata(client); gpiochip_remove(&mcp->chip); - kfree(mcp); return 0; } -- 2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv3 00/14] mcp23s08 pinconf & cleanup Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 09/14] pinctrl: mcp23s08: simplify i2c pdata handling Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 13/14] pinctrl: mcp23s08: drop comment about missing irq support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 03/14] pinctrl: mcp23s08: drop pullup config from pdata Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 07/14] pinctrl: mcp23s08: use managed kzalloc for mcp Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 12/14] pinctrl: mcp23s08: simplify spi_present_mask handling Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 08/14] pinctrl: mcp23s08: switch to devm_gpiochip_add_data Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 10/14] pinctrl: mcp23s08: simplify spi pdata handling Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 02/14] pinctrl: mcp23s08: add pinconf support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
Re: [PATCHv3 02/14] pinctrl: mcp23s08: add pinconf support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 14:40 +0200
[PATCHv3 05/14] pinctrl: mcp23s08: drop OF_GPIO dependency Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
[PATCHv3 01/14] gpio: mcp23s08: move to pinctrl Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
Re: [PATCHv3 01/14] gpio: mcp23s08: move to pinctrl Sylvain Lemieux <slemieux.tyco@gmail.com> - 2017-05-16 21:50 +0200
[PATCHv3 11/14] pinctrl: mcp23s08: generalize irq property handling Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-15 11:30 +0200
Re: [PATCHv3 00/14] mcp23s08 pinconf & cleanup Linus Walleij <linus.walleij@linaro.org> - 2017-05-23 10:00 +0200
csiph-web