Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times
Date	2017-05-15 10:00 +0200
Message-ID	<tHj59-5aS-27@gated-at.bofh.it> (permalink)
References	<tCooN-4aC-1@gated-at.bofh.it> <tCooN-4aC-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, May 01, 2017 at 11:37:15AM -0700, Matthias Kaehlcke wrote:

>  	else if (rdev->constraints->settling_time)
>  		return rdev->constraints->settling_time;
> +	else if (rdev->constraints->settling_time_up &&
> +		 (new_uV > old_uV))
> +		return rdev->constraints->settling_time_up;
> +	else if (rdev->constraints->settling_time_down &&
> +		 (new_uV < old_uV))
> +		return rdev->constraints->settling_time_down;

It feels like we should warn if the user mixes specific up/down settling
times with the more general property, can you please send a followup
patch adding a warning for that?  It's not exactly obvious what the
precedence is and may do the wrong thing with an older kernel or
non-Linux OS.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times Mark Brown <broonie@kernel.org> - 2017-05-15 10:00 +0200
  Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times Matthias Kaehlcke <mka@chromium.org> - 2017-05-16 01:00 +0200

csiph-web