Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641333

Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop tracking control

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, May 05, 2017 at 10:42:15AM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---

The subject line suggests that this is adding two new features.  Unless
they are very closely related in the code they should be submitted as
separate patches as covered in SubmittingPatches.

>  	default:
> -		dev_err(codec->dev, "DAI clock mode unsupported");
> +		dev_err(codec->dev, "DAI clock mode unsupported\n");
>  		return -EINVAL;
>  	}
>  

It also seems like there are a number of unrelated stylistic changes in
this patch.  While it's fine to make such changes they too should be in
separate patches.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop  tracking control Mark Brown <broonie@kernel.org> - 2017-05-15 10:00 +0200

csiph-web