Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641286

Re: [PATCH 2/2] ipack: Improve a size determination in ipack_bus_register()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello Markus,

Thanks for the patches!

Series is,

Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>

Greg, Would you mind picking this patch series through your char-misc
tree?

Sam

On Sat, 2017-05-13 at 10:56 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 13 May 2017 10:37:06 +0200
> 
> Replace the specification of a data structure by a pointer
> dereference
> as the parameter for the operator "sizeof" to make the corresponding
> size
> determination a bit safer according to the Linux coding style
> convention.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/ipack/ipack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
> index 575c4f29e0f7..a1e07a77d4e6 100644
> --- a/drivers/ipack/ipack.c
> +++ b/drivers/ipack/ipack.c
> @@ -212,7 +212,7 @@ struct ipack_bus_device
> *ipack_bus_register(struct device *parent, int slots,
>  	int bus_nr;
>  	struct ipack_bus_device *bus;
>  
> -	bus = kzalloc(sizeof(struct ipack_bus_device), GFP_KERNEL);
> +	bus = kzalloc(sizeof(*bus), GFP_KERNEL);
>  	if (!bus)
>  		return NULL;
>  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ipack: Improve a size determination in  ipack_bus_register() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-13 11:00 +0200
  Re: [PATCH 2/2] ipack: Improve a size determination in  ipack_bus_register() Samuel Iglesias Gonsálvez          <siglesias@igalia.com> - 2017-05-15 07:30 +0200
    Re: [PATCH 2/2] ipack: Improve a size determination in  ipack_bus_register() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-15 08:00 +0200
      Re: ipack: Improve a size determination in ipack_bus_register() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-15 08:50 +0200

csiph-web