Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions.

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	harinath Nampally <harinath922@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions.
Date	Mon, 15 May 2017 05:20:02 +0200
Message-ID	<tHeIa-2lr-9@gated-at.bofh.it> (permalink)
References	<tF84a-77W-27@gated-at.bofh.it> <tFn3b-i8-7@gated-at.bofh.it> <tFn3b-i8-9@gated-at.bofh.it> <tH3D3-3eR-9@gated-at.bofh.it>
X-Original-To	Jonathan Cameron <jic23@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QwrL0jOGtVerJZs8hIz1JROTVDBO52ZDMnzrKKLVlG4=; b=q/zd8Vhrpzr6n8d2leVov2p+bZ2b8fD8f30O/JQlEnUWS17l+G+5Dpjr0IWA2WALT8 X+osZMb/g4F++eQ7wbBBa7J14nz/OQ6pNDbQmqBoaH10UdEKbTJx7AgMZZZyAstuuhtf bT1da3e+c3CgmfWiqmVuLLXUG222m5RO7199WFlOEDTJeHt/nxnwuVvjAiVGCD0obK3J etaa9oK9RU9nni5/B35MAKLM/hTFB3us1w+iRYxUWo9xDby/zEIrYDb/A5Q178ofyIpg kU+PSsF3lV0Du1mxLCHdOWQVeeVCSIXxzrhpyWJW3QN2N+33pgv+r2Zw1a36JE6dAqNL 73qA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QwrL0jOGtVerJZs8hIz1JROTVDBO52ZDMnzrKKLVlG4=; b=nOvS29bgt5mUyg8ouiGkqOaO4h5rpxkEGTWGbi8kqSM5WN6pk1S6bWDcz7RtFvk6/G f5HwYqTchPpGJ1zzdsWEyQKouW4dXZUQ/HEievFEnKdEJ2BEkyeXynTwGFt7+NwNYWS5 7RGXxyRSJjPk5TP9BDx3EqHzALdF+frjE3csTJNUYmTvBJjJwEAFKuVPPaVgbDcRBMxM pygrB0ZEPOqxcwkw2Q4anqqWum15IwsK9AOFEsr63ei9WsKwwqleaSzTaJp+0m4n11Qw yDMaCtMWIbjH2QcgW5Umoq2xKBC8lHb5PHZxcWz9jkYVZgij5WdVKS8iNEhlW5KQSaaO tkoA==
X-Gm-Message-State	AODbwcCYK72P2DnLVaDwzwc7mLuJf0y40CjPoY5i9vkmQgDJN91m5Vn+ Euy9OT6jMCQnBXzchZKniwAIBVF7lw==
X-Received	by 10.200.55.103 with SMTP id p36mr3221731qtb.64.1494817851906; Sun, 14 May 2017 20:10:51 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	180
Organization	linux.* mail to news gateway
X-Original-Cc	lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Greg KH <gregkh@linuxfoundation.org>, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 14 May 2017 23:10:11 -0400
X-Original-Message-ID	<CAAGUq_rO+Gk4MVFD4bt9J6N0YqtK-WSFSY5D9k=rtQ6ONUYNcQ@mail.gmail.com>
X-Original-References	<20170509074617.x6bdqs7innxhrude@mwanda> <cover.1494370925.git.harinath922@gmail.com> <5f6a26eefe013534d892c98f3d502fb985fd4629.1494370925.git.harinath922@gmail.com> <326ada08-efba-5330-f9af-e23693839b6c@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1641258

Show key headers only | View raw

Jonathan,

Thank you for letting me know. In future I will work on 'togreg' branch
of iio.git tree to send my patches.

Thanks,
Harinath

On Sun, May 14, 2017 at 11:29 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 10/05/17 00:41, Harinath Nampally wrote:
>>
>> This patch fixes below kind of warnings:
>> WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.
>>
>> Below errors are false positives:
>> ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions
>> ade7753.c:386: ERROR: Use 4 digit octal (0777) not decimal permissions
>>
>> Signed-off-by: Harinath Nampally <harinath922@gmail.com>
>
> I've already taken a patch for this.
>
> For IIO patches (including for drivers in staging) please also
> check the iio.git tree and in particularly base the on the togreg branch
> of that unless you know something you need is in the testing branch
> (usually more recent) in which case use that.  This stuff all gets
> batched up every few weeks and sent as a pull request to Greg.
> Right now we have just ended a merge window so it's the longest gap
> that typically occurs in these going to Greg.
>
> Thanks,
>
> Jonathan
>
>> ---
>> Changes in v2:
>>   - None because only [PATCH v2 1/3] has improvement
>>
>>   drivers/staging/iio/meter/ade7753.c | 46
>> ++++++++++++++++++-------------------
>>   1 file changed, 23 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/staging/iio/meter/ade7753.c
>> b/drivers/staging/iio/meter/ade7753.c
>> index 5d45a68..2534bd0 100644
>> --- a/drivers/staging/iio/meter/ade7753.c
>> +++ b/drivers/staging/iio/meter/ade7753.c
>> @@ -298,92 +298,92 @@ static IIO_DEV_ATTR_AENERGY(ade7753_read_24bit,
>> ADE7753_AENERGY);
>>   static IIO_DEV_ATTR_LAENERGY(ade7753_read_24bit, ADE7753_LAENERGY);
>>   static IIO_DEV_ATTR_VAENERGY(ade7753_read_24bit, ADE7753_VAENERGY);
>>   static IIO_DEV_ATTR_LVAENERGY(ade7753_read_24bit, ADE7753_LVAENERGY);
>> -static IIO_DEV_ATTR_CFDEN(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_CFDEN(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_CFDEN);
>> -static IIO_DEV_ATTR_CFNUM(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_CFNUM(0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_CFNUM);
>>   static IIO_DEV_ATTR_CHKSUM(ade7753_read_8bit, ADE7753_CHKSUM);
>> -static IIO_DEV_ATTR_PHCAL(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_PHCAL(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_PHCAL);
>> -static IIO_DEV_ATTR_APOS(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_APOS(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_APOS);
>> -static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_SAGCYC(0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_SAGCYC);
>> -static IIO_DEV_ATTR_SAGLVL(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_SAGLVL(0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_SAGLVL);
>> -static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_LINECYC(0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_LINECYC);
>> -static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_WDIV(0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_WDIV);
>> -static IIO_DEV_ATTR_IRMS(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_IRMS(0644,
>>                 ade7753_read_24bit,
>>                 NULL,
>>                 ADE7753_IRMS);
>> -static IIO_DEV_ATTR_VRMS(S_IRUGO,
>> +static IIO_DEV_ATTR_VRMS(0444,
>>                 ade7753_read_24bit,
>>                 NULL,
>>                 ADE7753_VRMS);
>> -static IIO_DEV_ATTR_IRMSOS(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_IRMSOS(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_IRMSOS);
>> -static IIO_DEV_ATTR_VRMSOS(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_VRMSOS(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_VRMSOS);
>> -static IIO_DEV_ATTR_WGAIN(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_WGAIN(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_WGAIN);
>> -static IIO_DEV_ATTR_VAGAIN(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_VAGAIN(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_VAGAIN);
>> -static IIO_DEV_ATTR_PGA_GAIN(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_PGA_GAIN(0644,
>>                 ade7753_read_16bit,
>>                 ade7753_write_16bit,
>>                 ADE7753_GAIN);
>> -static IIO_DEV_ATTR_IPKLVL(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_IPKLVL(0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_IPKLVL);
>> -static IIO_DEV_ATTR_VPKLVL(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_VPKLVL(0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_VPKLVL);
>> -static IIO_DEV_ATTR_IPEAK(S_IRUGO,
>> +static IIO_DEV_ATTR_IPEAK(0444,
>>                 ade7753_read_24bit,
>>                 NULL,
>>                 ADE7753_IPEAK);
>> -static IIO_DEV_ATTR_VPEAK(S_IRUGO,
>> +static IIO_DEV_ATTR_VPEAK(0444,
>>                 ade7753_read_24bit,
>>                 NULL,
>>                 ADE7753_VPEAK);
>> -static IIO_DEV_ATTR_VPERIOD(S_IRUGO,
>> +static IIO_DEV_ATTR_VPERIOD(0444,
>>                 ade7753_read_16bit,
>>                 NULL,
>>                 ADE7753_PERIOD);
>> -static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_CH_OFF(1, 0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_CH1OS);
>> -static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_CH_OFF(2, 0644,
>>                 ade7753_read_8bit,
>>                 ade7753_write_8bit,
>>                 ADE7753_CH2OS);
>> @@ -514,7 +514,7 @@ static IIO_DEV_ATTR_TEMP_RAW(ade7753_read_8bit);
>>   static IIO_CONST_ATTR(in_temp_offset, "-25 C");
>>   static IIO_CONST_ATTR(in_temp_scale, "0.67 C");
>>   -static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
>> +static IIO_DEV_ATTR_SAMP_FREQ(0644,
>>                 ade7753_read_frequency,
>>                 ade7753_write_frequency);
>>
>
>



-- 
Thanks,
Harinath
+1 312 560 8565

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions  with octal permissions. Jonathan Cameron <jic23@kernel.org> - 2017-05-14 17:30 +0200
  Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions  with octal permissions. harinath Nampally <harinath922@gmail.com> - 2017-05-15 05:20 +0200

csiph-web