Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641228

Re: [PATCH v3] LSM: Enable multiple calls to security_add_hooks() for the same LSM

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From James Morris <jmorris@namei.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3] LSM: Enable multiple calls to security_add_hooks() for the same LSM
Date Mon, 15 May 2017 02:00:01 +0200
Message-ID <tHbAB-82-5@gated-at.bofh.it> (permalink)
References <tFGIx-5lI-13@gated-at.bofh.it>
User-Agent Alpine 2.20 (LRH 67 2015-01-07)
MIME-Version 1.0
Content-Type multipart/mixed; BOUNDARY="1665246916-871050174-1494806348=:29831"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 38
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, Casey Schaufler <casey@schaufler-ca.com>, James Morris <james.l.morris@oracle.com>, Kees Cook <keescook@chromium.org>, "Serge E . Hallyn" <serge@hallyn.com>, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, linux-security-module@vger.kernel.org
X-Original-Date Mon, 15 May 2017 09:59:07 +1000 (AEST)
X-Original-Message-ID <alpine.LRH.2.20.1705150958510.29831@namei.org>
X-Original-References <20170510204848.1555-1-mic@digikod.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1641228

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Wed, 10 May 2017, Mickaël Salaün wrote:

> The commit d69dece5f5b6 ("LSM: Add /sys/kernel/security/lsm") extend
> security_add_hooks() with a new parameter to register the LSM name,
> which may be useful to make the list of currently loaded LSM available
> to userspace. However, there is no clean way for an LSM to split its
> hook declarations into multiple files, which may reduce the mess with
> all the included files (needed for LSM hook argument types) and make the
> source code easier to review and maintain.
> 
> This change allows an LSM to register multiple times its hook while
> keeping a consistent list of LSM names as described in
> Documentation/security/LSM.txt . The list reflects the order in which
> checks are made. This patch only check for the last registered LSM. If
> an LSM register multiple times its hooks, interleaved with other LSM
> registrations (which should not happen), its name will still appear in
> the same order that the hooks are called, hence multiple times.
> 
> To sum up, "capability,selinux,foo,foo" will be replaced with
> "capability,selinux,foo", however "capability,foo,selinux,foo" will
> remain as is.

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next


-- 
James Morris
<jmorris@namei.org>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v3] LSM: Enable multiple calls to security_add_hooks()  for the same LSM James Morris <jmorris@namei.org> - 2017-05-15 02:00 +0200

csiph-web