Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1642920
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] gpu: drm: radeon: refactor code |
| Date | Wed, 17 May 2017 04:50:01 +0200 |
| Message-ID | <tHXcd-5H2-7@gated-at.bofh.it> (permalink) |
| X-Original-To | Alex Deucher <alexander.deucher@amd.com>, Christian König <christian.koenig@amd.com>, David Airlie <airlied@linux.ie> |
| X-Greylist | delayed 1285 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 May 2017 22:41:42 EDT |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| X-Antiabuse | This header was added to track abuse, please include it with any abuse report |
| X-Antiabuse | Primary Hostname - gator4166.hostgator.com |
| X-Antiabuse | Original Domain - vger.kernel.org |
| X-Antiabuse | Originator/Caller UID/GID - [47 12] / [47 12] |
| X-Antiabuse | Sender Address Domain - embeddedor.com |
| X-Bwhitelist | no |
| X-Source-IP | 189.152.179.187 |
| X-Exim-ID | 1dAoZR-00039a-8G |
| X-Source-Sender | (embeddedgus) [189.152.179.187]:39792 |
| X-Source-Auth | garsilva@embeddedor.com |
| X-Email-Count | 6 |
| X-Source-Cap | Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
| X-Original-Date | Tue, 16 May 2017 21:20:12 -0500 |
| X-Original-Message-ID | <20170517022012.GA11913@embeddedgus> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1642920 |
Show key headers only | View raw
Local variable _color_ is assigned to a constant value and it is never updated again. Remove this variable and refactor the code it affects. Addresses-Coverity-ID: 1226745 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c index 222a1fa..7235d0c 100644 --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c @@ -640,7 +640,6 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc uint32_t vclk_ecp_cntl, crtc_ext_cntl; uint32_t dac_ext_cntl, dac_cntl, dac_macro_cntl, tmp; enum drm_connector_status found = connector_status_disconnected; - bool color = true; /* just don't bother on RN50 those chip are often connected to remoting * console hw and often we get failure to load detect those. So to make @@ -665,12 +664,7 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc WREG32(RADEON_CRTC_EXT_CNTL, tmp); tmp = RADEON_DAC_FORCE_BLANK_OFF_EN | - RADEON_DAC_FORCE_DATA_EN; - - if (color) - tmp |= RADEON_DAC_FORCE_DATA_SEL_RGB; - else - tmp |= RADEON_DAC_FORCE_DATA_SEL_G; + RADEON_DAC_FORCE_DATA_EN | RADEON_DAC_FORCE_DATA_SEL_RGB; if (ASIC_IS_R300(rdev)) tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT); -- 2.5.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] gpu: drm: radeon: refactor code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-17 04:50 +0200 RE: [PATCH] gpu: drm: radeon: refactor code "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-05-23 17:40 +0200
csiph-web