[PATCH] seq_file: delete small-value optimization

From	Alexey Dobriyan <adobriyan@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] seq_file: delete small-value optimization
Date	2017-05-16 22:50 +0200
Message-ID	<tHRzQ-1XD-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

num_to_str() optimizes printing small integers [0..9], so the same
check higher in callchain is unnecessary.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 fs/seq_file.c |   10 ----------
 1 file changed, 10 deletions(-)

--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -694,11 +694,6 @@ void seq_put_decimal_ull(struct seq_file *m, const char *delimiter,
 	if (m->count + 1 >= m->size)
 		goto overflow;
 
-	if (num < 10) {
-		m->buf[m->count++] = num + '0';
-		return;
-	}
-
 	len = num_to_str(m->buf + m->count, m->size - m->count, num);
 	if (!len)
 		goto overflow;
@@ -733,11 +728,6 @@ void seq_put_decimal_ll(struct seq_file *m, const char *delimiter, long long num
 		num = -num;
 	}
 
-	if (num < 10) {
-		m->buf[m->count++] = num + '0';
-		return;
-	}
-
 	len = num_to_str(m->buf + m->count, m->size - m->count, num);
 	if (!len)
 		goto overflow;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] seq_file: delete small-value optimization Alexey Dobriyan <adobriyan@gmail.com> - 2017-05-16 22:50 +0200
  Re: [PATCH] seq_file: delete small-value optimization Joe Perches <joe@perches.com> - 2017-05-17 09:20 +0200

csiph-web