Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642668

Re: [PATCH 1/2] net-next: stmmac: add adjust_link function

Show all headers | View raw

From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Mon, 15 May 2017 13:41:39 +0200

> My dwmac-sun8i serie will add some if (has_sun8i) to
> stmmac_adjust_link()
> Since the current stmmac_adjust_link() alreaady have lots of if (has_gmac/gmac4),
> It is now better to create an adjust_link() function for each dwmac.
> 
> So this patch add an adjust_link() function pointer, and move code out
> of stmmac_adjust_link to it.
> 
> Removing in the process stmmac_mac_flow_ctrl/stmmac_hw_fix_mac_speed
> since there not used anymore.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

This will introduce crashes because you only added the adjust_link
method to one of the two stmmac_ops instances in
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c

Furthermore, a patch series should always have a header posting
with subject of the format "[PATCH 0/N]: xxx" which describes at
a high level what the patch series does as a whole, how it is doing
it, and why it is doing it that way.

Thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net-next: stmmac: add adjust_link function Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-15 13:50 +0200
  [PATCH 2/2] net-next: stmmac: remove struct mac_link Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-15 13:50 +0200
  Re: [PATCH 1/2] net-next: stmmac: add adjust_link function David Miller <davem@davemloft.net> - 2017-05-16 18:40 +0200
  Re: [PATCH 1/2] net-next: stmmac: add adjust_link function Florian Fainelli <f.fainelli@gmail.com> - 2017-05-16 18:50 +0200
    Re: [PATCH 1/2] net-next: stmmac: add adjust_link function Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-16 21:10 +0200
    Re: [PATCH 1/2] net-next: stmmac: add adjust_link function Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-17 10:30 +0200

csiph-web