Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642540

Re: [PATCH] rt2x00: improve calling conventions for register accessors

From Stanislaw Gruszka <sgruszka@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] rt2x00: improve calling conventions for register accessors
Date 2017-05-16 14:50 +0200
Message-ID <tHK5k-5F7-23@gated-at.bofh.it> (permalink)
References <tHoxQ-pi-37@gated-at.bofh.it> <tHpkd-Uz-3@gated-at.bofh.it> <tHptU-XY-23@gated-at.bofh.it> <tHJiW-59w-7@gated-at.bofh.it> <tHJiW-59w-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, May 16, 2017 at 01:58:56PM +0200, Johannes Berg wrote:
> On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote:
> > 
> > In rt2x00 driver we use poor convention in other kind of registers
> > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr
> > accessors and leaving others in the old way. And changing all
> > accessors would be massive and error prone change, which I'm not
> > prefer either.
> 
> That's a stupid argument, but for the sake of it - the conversion can
> easily be done with coccinelle/spatch without being "error prone".

Sure, but still I think it would be preferable to fix newly added
rt2800_bw_filter_calibration() function, instead of ancient rfcsr
accessors.

Stanislaw

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] rt2x00: improve calling conventions for register  accessors Stanislaw Gruszka <sgruszka@redhat.com> - 2017-05-15 16:40 +0200
  Re: [PATCH] rt2x00: improve calling conventions for register  accessors David Miller <davem@davemloft.net> - 2017-05-15 16:50 +0200
    Re: [PATCH] rt2x00: improve calling conventions for register  accessors Stanislaw Gruszka <sgruszka@redhat.com> - 2017-05-16 14:00 +0200
      Re: [PATCH] rt2x00: improve calling conventions for register  accessors Johannes Berg <johannes@sipsolutions.net> - 2017-05-16 14:00 +0200
        Re: [PATCH] rt2x00: improve calling conventions for register  accessors Stanislaw Gruszka <sgruszka@redhat.com> - 2017-05-16 14:50 +0200
        Re: [PATCH] rt2x00: improve calling conventions for register  accessors David Miller <davem@davemloft.net> - 2017-05-16 17:40 +0200
      Re: [PATCH] rt2x00: improve calling conventions for register  accessors Jes Sorensen <jes.sorensen@gmail.com> - 2017-05-16 15:50 +0200
        Re: [PATCH] rt2x00: improve calling conventions for register accessors Arnd Bergmann <arnd@arndb.de> - 2017-05-16 16:30 +0200
          Re: [PATCH] rt2x00: improve calling conventions for register  accessors Jes Sorensen <jes.sorensen@gmail.com> - 2017-05-16 16:40 +0200
            Re: [PATCH] rt2x00: improve calling conventions for register accessors Arnd Bergmann <arnd@arndb.de> - 2017-05-17 16:50 +0200
      Re: [PATCH] rt2x00: improve calling conventions for register  accessors Stanislaw Gruszka <sgruszka@redhat.com> - 2017-05-16 16:30 +0200
        Re: [PATCH] rt2x00: improve calling conventions for register accessors Arnd Bergmann <arnd@arndb.de> - 2017-05-16 17:20 +0200

csiph-web