Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642472

Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control
Date 2017-05-16 14:10 +0200
Message-ID <tHJsC-5rS-23@gated-at.bofh.it> (permalink)
References <tHsrL-2Pf-3@gated-at.bofh.it> <tHsrL-2Pf-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
> This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when synth_flush is called.

Minor nit, please line-wrap your changelog text at 72 columns so that I
don't have to do it "by hand".

> 
> It also tries to ensure that hardware flow control is enabled, by setting CRTSCTS using tty's termios.
> 
> Reported-by: John Covici <covici@ccs.covici.com>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> Index: linux-staging/drivers/staging/speakup/serialio.c
> ===================================================================

Are you using git?  These lines are odd...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control Okash Khawaja <okash.khawaja@gmail.com> - 2017-05-15 20:00 +0200
  Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure  hardware flow control Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-16 14:10 +0200
    Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure  hardware flow control Okash Khawaja <okash.khawaja@gmail.com> - 2017-05-16 14:20 +0200
      Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure  hardware flow control Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-16 14:30 +0200
        Re: [patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control Okash Khawaja <okash.khawaja@gmail.com> - 2017-05-16 15:00 +0200

csiph-web