[PATCH] fbdev: via: remove possibly unused variables

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] fbdev: via: remove possibly unused variables
Date	Tue, 16 May 2017 13:30:01 +0200
Message-ID	<tHIPT-4Yo-5@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.9.0
X-Provags-ID	V03:K0:8965khaTF8IvWd04AvLn5QKVurr50mvpC75adMnYM4+SvGd7G+l /8VITWb8yZt0i+w1dKmZbJwxx5Tvlo0rhTlRNWsrgZ7xbkd/kSJ5huluSrQSiijTwh0MppJ bAiXByD6mIy8Dzat5+WMwqPiyty27dzVSL3l0vTtRKVAMpVmqqLvzHPxavdhdDQ6Qxs0Pou b0vZg9bjrFAzLCiWaCwKg==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:2QOM/h31NWo=:esecuJ1R5H2x1dfnqWeqkf +GVr5GlIdzC4D11w3BRyQNrQHIajcQM68tIP2/MpjyKz6YzxqixI0p1I6NdzSWfKKxQe/Mk2j JvtDHL77ooq3zn3Nh6LSfjJuQfAY0GLq/geD7QiDU51GQ1KJa1IzTox3pek6cmrSP/pbcgU/B a4atKCBvGtxqOh7kN42Ph0FdXIIwGUfdjv4EJZvHSfKe1byuY6UqCszVjBpmY2Ww/2D/H/qNc 7ZLnThJbrYXjDPxKhWCAnb/QBQIQF+JZnKt5S6ANQ39aSId233caji/XHz4Rdz3RA6DmryJSF xGLM54Do2UV+j8FnpVcIcE+9yZCGf7gdea3MRPzdsQ+dtvLVOm3WnrhbwYSakB+YQf+AHUoGH ADUVlVVebbvgS1OZmzWSuFH9OoS9wJGlxdd68iLVYeCS1qkyeAwLvClqDOK7bqiw1tHyHUXmy 7itL5IzzKAywqyZfmWMURTWeiMpBODpiV954x2bZbaNtHPbDWbCj8TX5Ft9wm608rSi/HBkLp ERL11fOCcyzIjvr9LTagv4xyfh0sIBzo/vKAEOnfR5g7ApFMdHDUuHWSWO1U3R0fXtGrLB892 DcVZGNZje4oscW/yWpT7OsbLrtgZlf7E6/GY62roxIdGFNmENVvqSE0EZOigaKhYDzyUVoknp FdQJfTHS7SGpFA5vYyfbF+rbKLIaQsQaumZ6YDGg+ngXCoBG/Z35W000g/zdKfst8zDs=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Arnd Bergmann <arnd@arndb.de>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 16 May 2017 13:28:57 +0200
X-Original-Message-ID	<20170516112906.4144714-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1642426

Show key headers only | View raw

When CONFIG_PROC_FS is disabled, we get warnings about unused variables
as remove_proc_entry() evaluates to an empty macro.

drivers/video/fbdev/via/viafbdev.c: In function 'viafb_remove_proc':
drivers/video/fbdev/via/viafbdev.c:1635:4: error: unused variable 'iga2_entry' [-Werror=unused-variable]
drivers/video/fbdev/via/viafbdev.c:1634:4: error: unused variable 'iga1_entry' [-Werror=unused-variable]

These are easy to avoid by using the pointer from the structure.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/video/fbdev/via/viafbdev.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
index 510772bed4f4..89ee4d73bcff 100644
--- a/drivers/video/fbdev/via/viafbdev.c
+++ b/drivers/video/fbdev/via/viafbdev.c
@@ -1630,16 +1630,14 @@ static void viafb_init_proc(struct viafb_shared *shared)
 }
 static void viafb_remove_proc(struct viafb_shared *shared)
 {
-	struct proc_dir_entry *viafb_entry = shared->proc_entry,
-		*iga1_entry = shared->iga1_proc_entry,
-		*iga2_entry = shared->iga2_proc_entry;
+	struct proc_dir_entry *viafb_entry = shared->proc_entry;
 
 	if (!viafb_entry)
 		return;
 
-	remove_proc_entry("output_devices", iga2_entry);
+	remove_proc_entry("output_devices", shared->iga2_proc_entry);
 	remove_proc_entry("iga2", viafb_entry);
-	remove_proc_entry("output_devices", iga1_entry);
+	remove_proc_entry("output_devices", shared->iga1_proc_entry);
 	remove_proc_entry("iga1", viafb_entry);
 	remove_proc_entry("supported_output_devices", viafb_entry);
 
-- 
2.9.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] fbdev: via: remove possibly unused variables Arnd Bergmann <arnd@arndb.de> - 2017-05-16 13:30 +0200

csiph-web