Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1642429

[PATCH] [net, 4.12] mlx5e: add CONFIG_INET dependency

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH] [net, 4.12] mlx5e: add CONFIG_INET dependency
Date Tue, 16 May 2017 13:30:01 +0200
Message-ID <tHIPT-4Yo-15@gated-at.bofh.it> (permalink)
X-Original-To Saeed Mahameed <saeedm@mellanox.com>, Matan Barak <matanb@mellanox.com>, Leon Romanovsky <leonro@mellanox.com>
X-Mailer git-send-email 2.9.0
X-Provags-ID V03:K0:WpWjoUq5/pNim+jvtEEMhfJP/IECdvF4sx44tL74uMC6fFbKvWi uojOFEnvEca98Ew45OiPbbacuXqb4WSg7ldBwtVapbcb1rXRA+xMU7BZ1w5AOjOS9fv43Sg GAoIygdP0qNVIKsNgnpuOSATBINDotB1NJdyjXkmzL8IGt0OEvfQ+7tkYJN0rpKLaXndFwe wZt0aBgpoN30NDFfTPwlw==
X-Ui-Out-Filterresults notjunk:1;V01:K0:xaz35PyRzrM=:/u6lAUyFxG5KXnDjYyX8m+ GwPZiWb7e5LYmweRMsWHHDnfuOnxdZEW0XG4M/+K7z6EQHju5x1dMlfXsLLejTXYMHKiQGnLJ 0Zlaj/HOe+QU4i9mmFkWfKHiBDzHHVOEXuc0ZMjnCcXxCRWQCf00zhE0fNj9bvp+RDjD7usfQ LZA4Hnloyh7C6Gp3zD3EsTwdPTgDMrp+80v0thdShGOlp40/TKT1dh6P7mrUDp82vx0uXc8sP UUgLupAUacG32J+++HNJSdedSb8EzbUQFkY7HyQ6gEO+WsfxU7GpWPJddOy8MdMi250+LDi7e kghR2DRcdojNdjaPJkpWOE0UXb5B8F2MEjI9byfgvvrn0gTH/t4LBON0DnjYV3qfS4eEPw2aI vfXYy+C4sJPFqLNUrNsADeRsnDxGP9jZuN0z8uGNl35LPz8eRYNogirAfhtcOTfeI4i9i6bRw /QmDKNhJzDwOANyimZwMeKl5Nvn7nkDK9d4oGr/WCjsLiDU6BKD0Y5r2klYFy6Pvdepq/T8KD BE68irPlIrLJ7Rp39iOEVru2ZtzS4UgB4ktKEuGcyK5jb2XRG6B/3imBROfANIBBPntvofHPh T3FxDHUNjOpY5CaNRC9H3p3q2oaXK5ysKCOfZS9mRMcNIJuahmRvXpdDb4XVN0IGT9YakKBfd MsUihYi7wJcRI4S2Ok1m2MompJI7pkoBpJcgcDrGFxHcr/a3eZ7zQt/HYmUD26lPdY9c=
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 37
Organization linux.* mail to news gateway
X-Original-Cc Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>, Erez Shitrit <erezsh@mellanox.com>, Or Gerlitz <ogerlitz@mellanox.com>, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Tue, 16 May 2017 13:27:49 +0200
X-Original-Message-ID <20170516112807.4107417-1-arnd@arndb.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1642429

Show key headers only | View raw


We now reference the arp_tbl, which requires IPv4 support to be
enabled in the kernel, otherwise we get a link error:

drivers/net/built-in.o: In function `mlx5e_tc_update_neigh_used_value':
(.text+0x16afec): undefined reference to `arp_tbl'
drivers/net/built-in.o: In function `mlx5e_rep_neigh_init':
en_rep.c:(.text+0x16c16d): undefined reference to `arp_tbl'
drivers/net/built-in.o: In function `mlx5e_rep_netevent_event':
en_rep.c:(.text+0x16cbb5): undefined reference to `arp_tbl'

This adds a Kconfig dependency for it.

Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update flow")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Note: the mlxsw driver has referenced the same symbol for a while,
but had an implicit dependency on CONFIG_INET since it also depends
on SWITCHDEV.

 drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
index fc52d742b7f7..27251a78075c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
@@ -13,7 +13,7 @@ config MLX5_CORE
 
 config MLX5_CORE_EN
 	bool "Mellanox Technologies ConnectX-4 Ethernet support"
-	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
+	depends on NETDEVICES && ETHERNET && INET && PCI && MLX5_CORE
 	depends on IPV6=y || IPV6=n || MLX5_CORE=m
 	imply PTP_1588_CLOCK
 	default n
-- 
2.9.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] [net, 4.12] mlx5e: add CONFIG_INET dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-16 13:30 +0200
  Re: [PATCH] [net, 4.12] mlx5e: add CONFIG_INET dependency David Miller <davem@davemloft.net> - 2017-05-16 21:50 +0200

csiph-web