Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1642421

Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support

From Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support
Date 2017-05-16 13:20 +0200
Message-ID <tHIGf-4Ub-17@gated-at.bofh.it> (permalink)
References <tHoo9-lZ-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>  static u32 lpuart32_read(void __iomem *addr)
>  {
> -	return ioread32be(addr);
> +	return lpuart_is_be ? ioread32be(addr) : readl(addr);
>  }
>  
>  static void lpuart32_write(u32 val, void __iomem *addr)
>  {
> -	iowrite32be(val, addr);
> +	if (lpuart_is_be)
> +		iowrite32be(val, addr);
> +	else
> +		writel(val, addr);
>  }

What if this is ever executed on big endian system?

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register  support Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-16 13:20 +0200
  Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register  support Dong Aisheng <dongas86@gmail.com> - 2017-05-17 05:40 +0200
    Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register  support Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-17 07:40 +0200
      Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register  support Dong Aisheng <dongas86@gmail.com> - 2017-05-17 07:50 +0200
        Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register  support Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-17 08:00 +0200
          Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register  support Dong Aisheng <dongas86@gmail.com> - 2017-05-17 08:20 +0200
        Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-17 12:00 +0200
  Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-17 12:00 +0200

csiph-web