Re: [PATCH] perf report: fix off-by-one for non-activation frames

From	Milian Wolff <milian.wolff@kdab.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf report: fix off-by-one for non-activation frames
Date	2017-05-16 11:10 +0200
Message-ID	<tHGEp-3GY-7@gated-at.bofh.it> (permalink)
References	<tHpNg-1m3-21@gated-at.bofh.it> <tHpWW-1pB-29@gated-at.bofh.it> <tHzWh-7wv-5@gated-at.bofh.it>
Organization	KDAB (Deutschland) GmbH&Co KG, a KDAB Group company

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Dienstag, 16. Mai 2017 03:57:53 CEST Namhyung Kim wrote:
> On Mon, May 15, 2017 at 05:13:06PM +0200, Milian Wolff wrote:
> > On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote:
> > > As the documentation for dwfl_frame_pc says, frames that
> > > are no activation frames need to have their program counter
> > > decremented by one to properly find the function of the caller.
> > 
> > Note that this leaves the perf build against libunwind in the current,
> > broken state. I do not know how to detect the activation property there.
> > Does anyone else? See elfutils source code for what it is doing:
> > 
> > https://sourceware.org/git/?p=elfutils.git;a=blob;f=libdwfl/
> > dwfl_frame_pc.c;h=296c815b9c73f42d79ac1778d2a0c420b89ee4eb;hb=HEAD
> 
> It seems that you can use unw_is_signal_frame().

Thank you! The v2 patch I just sent now uses that and it seems to work 
reliably in my quick test.

Cheers

-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf report: fix off-by-one for non-activation frames Milian Wolff <milian.wolff@kdab.com> - 2017-05-15 17:10 +0200
  Re: [PATCH] perf report: fix off-by-one for non-activation frames Milian Wolff <milian.wolff@kdab.com> - 2017-05-15 17:20 +0200
    Re: [PATCH] perf report: fix off-by-one for non-activation frames Namhyung Kim <namhyung@kernel.org> - 2017-05-16 04:00 +0200
      Re: [PATCH] perf report: fix off-by-one for non-activation frames Milian Wolff <milian.wolff@kdab.com> - 2017-05-16 11:10 +0200

csiph-web