Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642275

Re: [PATCH v2] kbuild: skip install/check of headers right under uapi directories

Show all headers | View raw

Le 16/05/2017 à 07:15, Masahiro Yamada a écrit :
> Since commit 61562f981e92 ("uapi: export all arch specifics
> directories"), "make INSTALL_HDR_PATH=$root/usr headers_install"
> deletes standard glibc headers and others in $root/usr/include.
> 
> The cause of the issue is that headers_install now starts descending
> from arch/$(hdr-arch)/include/uapi with $root/usr/include for its
> destination when installing asm headers.  So, headers already there
> are assumed to be unwanted.
> 
> When headers_install starts descending from include/uapi with
> $root/usr/include for its destination, it works around the problem
> by creating an dummy destination $root/usr/include/uapi, but this
> is tricky.
> 
> To fix the problem in a clean way is to skip headers install/check
> in include/uapi or arch/$(hdr-arch)/include/uapi because we know
> there are only sub-directories in uapi directories.  A good side
> effect is the empty destination $root/usr/include/uapi will go
> away.
> 
> I am also removing the trailing slash in the headers_check target to
> skip checking in arch/$(hdr-arch)/include/uapi.
> 
> Fixes: 61562f981e92 ("uapi: export all arch specifics directories")
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thank you for the patch.

Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] kbuild: skip install/check of headers right under uapi directories Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-16 07:20 +0200
  Re: [PATCH v2] kbuild: skip install/check of headers right under uapi  directories Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2017-05-16 09:50 +0200
    Re: [PATCH v2] kbuild: skip install/check of headers right under uapi directories Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-17 19:30 +0200

csiph-web