Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function
Date	2017-05-16 10:10 +0200
Message-ID	<tHFIm-36E-19@gated-at.bofh.it> (permalink)
References	<tDLW1-2wh-11@gated-at.bofh.it> <tGcp3-rT-1@gated-at.bofh.it> <tHoHw-sA-15@gated-at.bofh.it> <tHBOp-lH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 15/05/2017 at 20:51:30 -0700, Oliver Hartkopp wrote:
> On 05/15/2017 06:50 AM, Marc Kleine-Budde wrote:
> > On 05/12/2017 08:37 AM, Quentin Schulz wrote:
> > > On 05/05/2017 15:50, Quentin Schulz wrote:
> > > > To avoid possible ECC/parity checksum errors when reading an
> > > > uninitialized buffer, the entire Message RAM is initialized when probing
> > > > the driver. This initialization is done in the same function reading the
> > > > Device Tree properties.
> > > > 
> > > > This patch moves the RAM initialization to a separate function so it can
> > > > be called separately from device initialization from Device Tree.
> > > > 
> > > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> > > 
> > > It's been a week since I sent this patch series. Any comments?
> > 
> > Looks good, added to linux-can-next.
> 
> Isn't this a fix for linux-can instead?
> 
> At least it would make no sense to me to have the upgraded M_CAN driver in
> Linux 4.12 without this fix.
> 

The related suspend mode on the sama5d2 is not present in v4.12 so I
think this can wait v4.13.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to  function Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-05-12 08:40 +0200
  Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to  function Marc Kleine-Budde <mkl@pengutronix.de> - 2017-05-15 16:00 +0200
    Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to  function Oliver Hartkopp <socketcan@hartkopp.net> - 2017-05-16 06:00 +0200
      Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to  function Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-16 10:10 +0200
        Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to  function Oliver Hartkopp <socketcan@hartkopp.net> - 2017-05-16 15:20 +0200

csiph-web