Re: [PATCH v3 2/4] hwmon: (adt7475) fan stall prevention

From	Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/4] hwmon: (adt7475) fan stall prevention
Date	2017-05-14 23:10 +0200
Message-ID	<tH8W6-6Sd-31@gated-at.bofh.it> (permalink)
References	<tFNgZ-11V-3@gated-at.bofh.it> <tFNgZ-11V-1@gated-at.bofh.it> <tH3a2-2Q4-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 15/05/17 02:54, Guenter Roeck wrote:
> On 05/10/2017 08:45 PM, Chris Packham wrote:
>> By default adt7475 will stop the fans (pwm duty cycle 0%) when the
>> temperature drops past Tmin - hysteresis. Some systems want to keep the
>> fans moving even when the temperature drops so add new sysfs attributes
>> that configure the enhanced acoustics min 1-3 which allows the fans to
>> run at the minimum configure pwm duty cycle.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> ---
>>
>> Changes in v2:
>> - use pwmN_stall_dis as the attribute name. I think this describes the purpose
>>   pretty well. I went with a new attribute instead of overloading
>
> Almost agree. Can we use pwmN_stall_disable ?
>

Sold. I'll send a v4 of this patch with the name changed.

> Thanks,
> Guenter
>
>
>>   pwmN_auto_point1_pwm so this doesn't affect existing users.
>> Changes in v3:
>> - Fix grammar.
>> - change enh_acou to enh_acoustics

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/4] hwmon: (adt7475) fan stall prevention Guenter Roeck <linux@roeck-us.net> - 2017-05-14 17:00 +0200
  Re: [PATCH v3 2/4] hwmon: (adt7475) fan stall prevention Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-05-14 23:10 +0200

csiph-web