Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641190

[patch 08/18] mm: Adjust system_state check

Show all headers | View raw

To enable smp_processor_id() and might_sleep() debug checks earlier, it's
required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.

get_nid_for_pfn() checks for system_state == BOOTING to decide whether to
use early_pfn_to_nid() when CONFIG_DEFERRED_STRUCT_PAGE_INIT=y.

That check is dubious, because the switch to state RUNNING happes way after
page_alloc_init_late() has been invoked.

Change the check to less than RUNNING state so it covers the new
intermediate states as well.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/base/node.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -377,7 +377,7 @@ static int __ref get_nid_for_pfn(unsigne
 	if (!pfn_valid_within(pfn))
 		return -1;
 #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
-	if (system_state == SYSTEM_BOOTING)
+	if (system_state < SYSTEM_RUNNING)
 		return early_pfn_to_nid(pfn);
 #endif
 	page = pfn_to_page(pfn);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch 00/18] init: Enable might_sleep() and smp_processor_id()  debugging early Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
  [patch 09/18] cpufreq/pasemi: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
    Re: [patch 09/18] cpufreq/pasemi: Adjust system_state check Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-15 07:30 +0200
      Re: [patch 09/18] cpufreq/pasemi: Adjust system_state check Steven Rostedt <rostedt@goodmis.org> - 2017-05-15 16:40 +0200
  [patch 13/18] extable: Adjust system_state checks Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
    Re: [patch 13/18] extable: Adjust system_state checks Steven Rostedt <rostedt@goodmis.org> - 2017-05-15 16:40 +0200
  [patch 08/18] mm: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
    Re: [patch 08/18] mm: Adjust system_state check Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-15 08:20 +0200
      Re: [patch 08/18] mm: Adjust system_state check Steven Rostedt <rostedt@goodmis.org> - 2017-05-15 16:40 +0200
  [patch 01/18] init: Pin init task to boot cpu initially Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
    Re: [patch 01/18] init: Pin init task to boot cpu initially Steven Rostedt <rostedt@goodmis.org> - 2017-05-15 16:20 +0200
  Re: [patch 12/18] async: Adjust system_state checks Arjan van de Ven <arjan@linux.intel.com> - 2017-05-14 20:50 +0200
  [patch 05/18] metag: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
  [patch 02/18] arm: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
  [patch 18/18] sched: Enable smp_processor_id() checks early Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
    Re: [patch 18/18] sched: Enable smp_processor_id() checks early Steven Rostedt <rostedt@goodmis.org> - 2017-05-15 17:20 +0200
      Re: [patch 18/18] sched: Enable smp_processor_id() checks early Thomas Gleixner <tglx@linutronix.de> - 2017-05-15 17:40 +0200
  [patch 12/18] async: Adjust system_state checks Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
  Re: [patch 00/18] init: Enable might_sleep() and smp_processor_id()  debugging early Mark Rutland <mark.rutland@arm.com> - 2017-05-15 14:00 +0200

csiph-web