Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1641116
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition. |
| Date | 2017-05-14 17:30 +0200 |
| Message-ID | <tH3D3-3eR-1@gated-at.bofh.it> (permalink) |
| References | <tF84a-77W-27@gated-at.bofh.it> <tFn3b-i8-7@gated-at.bofh.it> <tFn3b-i8-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/05/17 00:41, Harinath Nampally wrote:
> This patch fixes below checkpatch.pl warning:
> CHECK: struct mutex definition without comment
>
> Signed-off-by: Harinath Nampally <harinath922@gmail.com>
They description is no longer correct. This moves a comment
rather than adding one.
J
> ---
> Changes in v2:
> - Removed the extra comment for mutex in the struct.
>
> drivers/staging/iio/meter/ade7753.c | 3 ++-
> 1 file changed, 1 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
> index b71fbd3..cffe6bf 100644
> --- a/drivers/staging/iio/meter/ade7753.c
> +++ b/drivers/staging/iio/meter/ade7753.c
> @@ -78,12 +78,13 @@
> /**
> * struct ade7753_state - device instance specific data
> * @us: actual spi_device
> + * @buf_lock: mutex to protect tx and rx
> * @tx: transmit buffer
> * @rx: receive buffer
> - * @buf_lock: mutex to protect tx and rx
> **/
> struct ade7753_state {
> struct spi_device *us;
> struct mutex buf_lock;
> u8 tx[ADE7753_MAX_TX] ____cacheline_aligned;
> u8 rx[ADE7753_MAX_RX];
>
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition. Jonathan Cameron <jic23@kernel.org> - 2017-05-14 17:30 +0200
csiph-web