Re: [PATCH v2] serial: exar: Fix stuck MSIs

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] serial: exar: Fix stuck MSIs
Date	2017-05-14 13:40 +0200
Message-ID	<tH02u-10Y-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <tzIam-56i-17@gated-at.bofh.it> <tzIWJ-5lR-3@gated-at.bofh.it> <tzJzs-5R1-15@gated-at.bofh.it> <tzKYx-6Qa-11@gated-at.bofh.it> <tGzlE-kx-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, May 13, 2017 at 09:09:17AM +0200, Jan Kiszka wrote:
> On 2017-04-24 14:07, Andy Shevchenko wrote:
> > On Mon, 2017-04-24 at 12:30 +0200, Jan Kiszka wrote:
> >> After migrating 8250_exar to MSI in 172c33cb61da, we can get stuck
> >> without further interrupts because of the special wake-up event these
> >> chips send. They are only cleared by reading INT0. As we fail to do so
> >> during startup and shutdown, we can leave the interrupt line asserted,
> >> which is fatal with edge-triggered MSIs.
> >>
> >> Add the required reading of INT0 to startup and shutdown. Also account
> >> for the fact that a pending wake-up interrupt means we have to return
> >> 1
> >> from exar_handle_irq. Drop the unneeded reading of INT1..3 along with
> >> this - those never reset anything.
> >>
> >> An alternative approach would have been disabling the wake-up
> >> interrupt.
> >> Unfortunately, this feature (REGB[17] = 1) is not available on the
> >> XR17D15X.
> > 
> > FWIW:
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> 
> Ping. Needs to go into stable 4.11 now as well.

Relax, I'll get to it after 4.12-rc1 is out...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] serial: exar: Fix stuck MSIs Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:10 +0200
  Re: [PATCH v2] serial: exar: Fix stuck MSIs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-14 13:40 +0200

csiph-web