Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same device

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same device
Date	2017-05-12 16:10 +0200
Message-ID	<tGjqz-5DF-43@gated-at.bofh.it> (permalink)
References	<tG2zn-2xc-7@gated-at.bofh.it> <tG489-3lp-7@gated-at.bofh.it> <tGe7v-1Ju-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Nikita Yushchenko <nikita.yoush@cogentembedded.com> [170512 01:22]:
> >> +		/*
> >> +		 * If pctldev is not null, we are claiming hog for it,
> >> +		 * that means, setting that is served by pctldev by itself.
> >> +		 *
> >> +		 * Thus we must skip map that is for this device but is served
> >> +		 * by other device.
> >> +		 */
> >> +		if (pctldev &&
> >> +		    strcmp(dev_name(pctldev->dev), map->ctrl_dev_name))
> >> +			continue;
> >>  
> >>  		ret = add_setting(p, pctldev, map);
> >>  		/*
> >> -- 
> > 
> > Maybe add a comment saying pctldev is NULL in the regular case
> > and only exists in the hog case?
> 
> Isn't comment above saying exactly that?

Yes it is, you're right :)

Tony

Thread

[PATCH] pinctrl: when claiming hog, skip maps not served by same device Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-11 22:10 +0200
  Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same  device Tony Lindgren <tony@atomide.com> - 2017-05-11 23:50 +0200
    Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same  device Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-12 10:30 +0200
      Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same  device Tony Lindgren <tony@atomide.com> - 2017-05-12 16:10 +0200
  Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same device Linus Walleij <linus.walleij@linaro.org> - 2017-05-22 17:10 +0200

csiph-web