Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640503
| From | Peter Ujfalusi <peter.ujfalusi@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 4/9] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program |
| Date | 2017-05-12 16:20 +0200 |
| Message-ID | <tGjAe-5JJ-21@gated-at.bofh.it> (permalink) |
| References | <tGjgR-5jQ-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Having one musb_ep_select() instead the two calls in if/else is the same
thing, but makes the code a bit simpler to follow.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Tony Lindgren <tony@atomide.com>
---
drivers/usb/musb/tusb6010_omap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c
index 7870b37e0ea5..025b52e0b34d 100644
--- a/drivers/usb/musb/tusb6010_omap.c
+++ b/drivers/usb/musb/tusb6010_omap.c
@@ -368,15 +368,14 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz,
/*
* Prepare MUSB for DMA transfer
*/
+ musb_ep_select(mbase, chdat->epnum);
if (chdat->tx) {
- musb_ep_select(mbase, chdat->epnum);
csr = musb_readw(hw_ep->regs, MUSB_TXCSR);
csr |= (MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAENAB
| MUSB_TXCSR_DMAMODE | MUSB_TXCSR_MODE);
csr &= ~MUSB_TXCSR_P_UNDERRUN;
musb_writew(hw_ep->regs, MUSB_TXCSR, csr);
} else {
- musb_ep_select(mbase, chdat->epnum);
csr = musb_readw(hw_ep->regs, MUSB_RXCSR);
csr |= MUSB_RXCSR_DMAENAB;
csr &= ~(MUSB_RXCSR_AUTOCLEAR | MUSB_RXCSR_DMAMODE);
--
2.13.0
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v3 0/9] usb: musb: tusb6010_omap: Convert to DMAengine Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-05-12 16:00 +0200
[PATCH v3 1/9] dmaengine: omap-dma: port_window support correction for both direction Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-05-12 16:00 +0200
Re: [PATCH v3 1/9] dmaengine: omap-dma: port_window support correction for both direction Vinod Koul <vinod.koul@intel.com> - 2017-05-14 15:10 +0200
[PATCH v3 2/9] usb: musb: Add quirk to avoid skb reserve in gadget mode Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-05-12 16:00 +0200
[PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-05-12 16:00 +0200
Re: [PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters Bin Liu <b-liu@ti.com> - 2017-05-17 22:20 +0200
Re: [PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters Bin Liu <b-liu@ti.com> - 2017-05-17 22:40 +0200
[PATCH v3 7/9] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-05-12 16:00 +0200
[PATCH v3 3/9] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-05-12 16:00 +0200
Re: [PATCH v3 3/9] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks Bin Liu <b-liu@ti.com> - 2017-05-17 22:10 +0200
[PATCH v3 4/9] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-05-12 16:20 +0200
csiph-web