Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640363
| From | Nicholas Piggin <npiggin@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1 |
| Date | 2017-05-12 11:50 +0200 |
| Message-ID | <tGfmV-2vB-3@gated-at.bofh.it> (permalink) |
| References | <tGf3A-2n7-9@gated-at.bofh.it> |
| Organization | IBM |
On Fri, 12 May 2017 14:52:06 +0530
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com> wrote:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>
> commit 17ed4c8f81da ("powerpc/powernv: Recover correct PACA on wakeup
> from a stop on P9 DD1") promises to set the NAPSTATELOST bit in paca
> after recovering the correct paca for the thread waking up from stop1
> on DD1, so that the GPRs can be correctly restored on the stop exit
> path. However, it loads the value 1 into r3, but stores the value in
> r0 into NAPSTATELOST(r13).
>
> Fix this by correctly set the NAPSTATELOST bit in paca after
> recovering the paca on POWER9 DD1.
>
> Fixes: commit 17ed4c8f81da ("powerpc/powernv: Recover correct PACA on wakeup
> from a stop on P9 DD1")
>
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
This looks obviously correct to me.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> arch/powerpc/kernel/idle_book3s.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/idle_book3s.S b/arch/powerpc/kernel/idle_book3s.S
> index 07d4e0a..4898d67 100644
> --- a/arch/powerpc/kernel/idle_book3s.S
> +++ b/arch/powerpc/kernel/idle_book3s.S
> @@ -416,7 +416,7 @@ power9_dd1_recover_paca:
> * which needs to be restored from the stack.
> */
> li r3, 1
> - stb r0,PACA_NAPSTATELOST(r13)
> + stb r3,PACA_NAPSTATELOST(r13)
> blr
>
> /*
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1 "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-05-12 11:30 +0200 Re: [PATCH] powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1 Nicholas Piggin <npiggin@gmail.com> - 2017-05-12 11:50 +0200 Re: powernv:idle: Set NAPSTATELOST after recovering paca on P9 DD1 Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-05-17 11:40 +0200
csiph-web