Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Milian Wolff <milian.wolff@kdab.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode
Date	Fri, 12 May 2017 12:30:01 +0200
Message-ID	<tGfZD-321-5@gated-at.bofh.it> (permalink)
References	<tFkoF-6Y6-17@gated-at.bofh.it> <tFsYW-5x7-5@gated-at.bofh.it>
Organization	KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
MIME-Version	1.0
Content-Type	multipart/signed; boundary="nextPart3988323.jnKMsYBGLQ"; micalg="sha1"; protocol="application/pkcs7-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	160
X-Original-Cc	Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>, David Ahern <dsahern@gmail.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Yao Jin <yao.jin@linux.intel.com>, kernel-team@lge.com
X-Original-Date	Fri, 12 May 2017 12:23:06 +0200
X-Original-Message-ID	<1866798.U7tsNezOxe@agathebauer>
X-Original-References	<20170509205046.21473-1-milian.wolff@kdab.com> <20170510060423.GB2667@sejong>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1640383

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mittwoch, 10. Mai 2017 08:04:23 CEST Namhyung Kim wrote:
> On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote:

<snip>

> > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> > index 9ab68682c6d0..295f0846fd84 100644
> > --- a/tools/perf/util/callchain.c
> > +++ b/tools/perf/util/callchain.c
> > @@ -642,13 +642,22 @@ static enum match_result match_chain_strings(const
> > char *left,> 
> >  static enum match_result match_chain_srcline(struct callchain_cursor_node
> >  *node,>  
> >  					     struct callchain_list *cnode)
> >  
> >  {
> > 
> > -	char *left = get_srcline(cnode->ms.map->dso,
> > -				 map__rip_2objdump(cnode->ms.map, cnode->ip),
> > -				 cnode->ms.sym, true, false);
> > -	char *right = get_srcline(node->map->dso,
> > -				  map__rip_2objdump(node->map, node->ip),
> > -				  node->sym, true, false);
> > -	enum match_result ret = match_chain_strings(left, right);
> > +	char *left = NULL;
> > +	char *right = NULL;
> > +	enum match_result ret = MATCH_ERROR;
> > +
> > +	if (!node->map || !cnode->ms.map)
> > +		return ret;
> 
> This makes it fall back to function/address matching below if one of
> srcline is not available.  But it'll just show many "??:0" entries
> IMHO.  Maybe we can use same logic in util/sort.c:cmp_null instead..

Yes, that could be done but I think it's not directly related to the patch/fix 
at hand. Would it be OK if I change this behavior in a separate patch?

Thanks
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Thread

[PATCH] perf report: don't crash on invalid maps in `-g srcline` mode Milian Wolff <milian.wolff@kdab.com> - 2017-05-09 23:00 +0200
  Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline`  mode Namhyung Kim <namhyung@kernel.org> - 2017-05-10 08:10 +0200
    Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode Milian Wolff <milian.wolff@kdab.com> - 2017-05-12 12:30 +0200
      Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline`  mode Namhyung Kim <namhyung@kernel.org> - 2017-05-12 14:20 +0200
  Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline`  mode Paul Clarke <pc@us.ibm.com> - 2017-05-11 15:20 +0200

csiph-web