Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1640256

Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

Show all headers | View raw

>> Just because an automated tool says that this needs to change does not
>> mean it has to.
> 
> Checkpatch.pl is correct here.  This message is useless.  It's during
> init so it's unlikely to fail ever.  In current kernels small kmallocs
> are quaranteed to succeed so it can't actually fail currently.  The
> stack trace is more useful than this message because it tells you a lot
> about what memory is free and the whole call tree.
> 
> The error message is dead useless code.

Would you like to clarify corresponding software evolution any more?

Is there a need for better documentation of the involved programming interfaces?


> This patch is not going to be merged because Markus doesn't listen to
> feedback and he's blocked but otherwise it's an OK patch.

Does this information contain a contradiction?
Will patches be picked up also from contributors who got a special
development reputation anyhow?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] vmbus: Delete an error message for a failed memory  allocation in vmbus_device_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 18:20 +0200
  Re: vmbus: Delete an error message for a failed memory allocation in  vmbus_device_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 18:40 +0200
    Re: vmbus: Delete an error message for a failed memory allocation  in vmbus_device_create() Stephen Hemminger <stephen@networkplumber.org> - 2017-05-11 18:50 +0200
  Re: [PATCH 2/4] vmbus: Delete an error message for a failed memory  allocation in vmbus_device_create() Stephen Hemminger <stephen@networkplumber.org> - 2017-05-11 18:40 +0200
    Re: [PATCH 2/4] vmbus: Delete an error message for a failed memory  allocation in vmbus_device_create() Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-12 09:20 +0200
      Re: vmbus: Delete an error message for a failed memory allocation in  vmbus_device_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-12 09:40 +0200
        Re: vmbus: Delete an error message for a failed memory allocation  in vmbus_device_create() Joe Perches <joe@perches.com> - 2017-05-12 10:00 +0200
          Re: Clarification for general change acceptance SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-12 10:30 +0200
            Re: Clarification for general change acceptance Julia Lawall <julia.lawall@lip6.fr> - 2017-05-12 10:40 +0200
              Re: Clarification for general change acceptance SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-12 10:50 +0200

csiph-web