Re: [greybus-dev] [PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [greybus-dev] [PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc
Date	2017-05-12 07:40 +0200
Message-ID	<tGbsZ-8fz-3@gated-at.bofh.it> (permalink)
References	<tG3vu-37w-57@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11-05-17, 22:58, JB Van Puyvelde wrote:
> According to checkpatch.pl, kcalloc should be preferred to kzalloc with
> multiply.
> 
> Signed-off-by: JB Van Puyvelde <jbvanpuyvelde@gmail.com>
> ---
>  drivers/staging/greybus/power_supply.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You should have kept my Ack in this patch, as I have already given it earlier.
Anyway, here it is again.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

> 
> diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c
> index e85c988b7034..20cac20518d7 100644
> --- a/drivers/staging/greybus/power_supply.c
> +++ b/drivers/staging/greybus/power_supply.c
> @@ -944,7 +944,7 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies)
>  	if (ret < 0)
>  		goto out;
>  
> -	supplies->supply = kzalloc(supplies->supplies_count *
> +	supplies->supply = kcalloc(supplies->supplies_count,
>  				     sizeof(struct gb_power_supply),
>  				     GFP_KERNEL);
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> greybus-dev mailing list
> greybus-dev@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/greybus-dev

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc JB Van Puyvelde <jbvanpuyvelde@gmail.com> - 2017-05-11 23:10 +0200
  Re: [PATCH] staging: greybus: power_supply: replace kzalloc by  kcalloc Rui Miguel Silva <rmfrfs@gmail.com> - 2017-05-11 23:30 +0200
  Re: [greybus-dev] [PATCH] staging: greybus: power_supply: replace  kzalloc by kcalloc Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-12 07:40 +0200

csiph-web