Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1640919

Re: [PATCH 8/8] serial: exar: Add support for IOT2040 device

Show all headers | View raw

On Sat, May 13, 2017 at 10:29 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> This implements the setup of RS232 and the switch-over to RS485 or RS422
> for the Siemens IOT2040. That uses an EXAR XR17V352 with external logic
> to switch between the different modes. The external logic is controlled
> via MPIO pins of the EXAR controller.
>
> Only pin 10 can be exported as GPIO on the IOT2040. It is connected to
> an LED.
>
> As the XR17V352 used on the IOT2040 is not equipped with an external
> EEPROM, it cannot present itself as IOT2040-variant via subvendor/
> subdevice IDs. Thus, we have to check via DMI for the target platform.
>
> Co-developed with Sascha Weisenberger.
>

Please, refactor that using properly formed DMI structrure and use its
callback and driver data facilities/

stmmac's pattern that you obviously applied does not actually suit here.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 8/8] serial: exar: Add support for IOT2040 device Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:40 +0200
  Re: [PATCH 8/8] serial: exar: Add support for IOT2040 device Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-13 16:00 +0200
    Re: [PATCH 8/8] serial: exar: Add support for IOT2040 device Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-18 07:10 +0200
      Re: [PATCH 8/8] serial: exar: Add support for IOT2040 device Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 12:20 +0200
        Re: [PATCH 8/8] serial: exar: Add support for IOT2040 device Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-18 12:40 +0200
          Re: [PATCH 8/8] serial: exar: Add support for IOT2040 device Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 13:40 +0200

csiph-web