Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640153
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] net: dsa: mv88e6xxx: add default case to switch |
| Date | 2017-05-12 05:20 +0200 |
| Message-ID | <tG9hw-6RZ-11@gated-at.bofh.it> (permalink) |
| References | <tG8Ot-6rP-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Add default case to switch in order to avoid any chance of using an uninitialized variable _low_, in case s->type does not match any of the listed case values. Addresses-Coverity-ID: 1398130 Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/net/dsa/mv88e6xxx/chip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 03dc886..d39e210 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -879,6 +879,9 @@ static uint64_t _mv88e6xxx_get_ethtool_stat(struct mv88e6xxx_chip *chip, mv88e6xxx_g1_stats_read(chip, reg, &low); if (s->sizeof_stat == 8) mv88e6xxx_g1_stats_read(chip, reg + 1, &high); + break; + default: + return UINT64_MAX; } value = (((u64)high) << 16) | low; return value; -- 2.5.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[net-dsa-mv88e6xxx] question about potential use of uninitialized variable "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-11 23:40 +0200
Re: [net-dsa-mv88e6xxx] question about potential use of uninitialized variable Andrew Lunn <andrew@lunn.ch> - 2017-05-12 04:40 +0200
Re: [net-dsa-mv88e6xxx] question about potential use of uninitialized variable "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-12 04:50 +0200
[PATCH] net: dsa: mv88e6xxx: add default case to switch "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-12 05:20 +0200
Re: [PATCH] net: dsa: mv88e6xxx: add default case to switch David Miller <davem@davemloft.net> - 2017-05-12 18:20 +0200
csiph-web