Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero

From	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
Date	2017-05-12 04:00 +0200
Message-ID	<tG825-5LR-3@gated-at.bofh.it> (permalink)
References	<tixO1-76a-3@gated-at.bofh.it> <tiyh4-7wX-5@gated-at.bofh.it> <tyEBQ-55T-15@gated-at.bofh.it> <tAGzv-1XN-7@gated-at.bofh.it> <tECnF-34t-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 2017-05-07 at 19:20 +0200, Borislav Petkov wrote:
> On Wed, Apr 26, 2017 at 06:29:59PM -0700, Ricardo Neri wrote:
> > > 	if (X86_MODRM_MOD(insn->modrm.value) == 0 &&
> > > 	    X86_MODRM_RM(insn->modrm.value)  == 5)
> > > 
> > > looks more understandable to me.
> > 
> > Should I go with !(X86_MODRM_MOD(insn->modrm.value)) as you suggested in
> > other patches?
> 
> Ah, yes pls.
> 
 I did this in v7[1].

Thanks and BR,
Ricardo

[1]. https://lkml.org/lkml/2017/5/5/399

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod  in ModRM is zero Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-04-27 03:40 +0200
  Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod  in ModRM is zero Borislav Petkov <bp@suse.de> - 2017-05-08 00:00 +0200
    Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod  in ModRM is zero Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-05-12 04:00 +0200

csiph-web