Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1640084

Re: [PATCH v9 7/9] coresight: add support for CPU debug module

Show all headers | View raw

On Thu, May 11, 2017 at 11:12:32AM -0600, Mathieu Poirier wrote:

[...]

> > +static int debug_probe(struct amba_device *adev, const struct amba_id *id)
> > +{
> > +	void __iomem *base;
> > +	struct device *dev = &adev->dev;
> > +	struct debug_drvdata *drvdata;
> > +	struct resource *res = &adev->res;
> > +	struct device_node *np = adev->dev.of_node;
> > +	int ret;
> > +
> > +	drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
> > +	if (!drvdata)
> > +		return -ENOMEM;
> > +
> > +	drvdata->cpu = np ? of_coresight_get_cpu(np) : 0;
> > +	if (per_cpu(debug_drvdata, drvdata->cpu)) {
> > +		dev_err(dev, "CPU%d drvdata has been initialized, "
> 
> s/"has been"/"has already been"
> 
> That way it really look like an error message.

Will fix.

> Also debug_probe() uses dev_xyz() but everywhere else in the driver it is
> pr_xyz() - any specific reason for that?  I suggest moving to dev_xyz().

Some logs are shared for all device instances, so I think should use
pr_xyz(); will spin a new version to change other places to use
dev_xyz() if the logs are for specific device instance.

> Otherwise things look good.

[...]

Thanks,
Leo Yan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v9 7/9] coresight: add support for CPU debug module Leo Yan <leo.yan@linaro.org> - 2017-05-09 05:00 +0200
  Re: [PATCH v9 7/9] coresight: add support for CPU debug module Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-05-11 19:20 +0200
    Re: [PATCH v9 7/9] coresight: add support for CPU debug module Leo Yan <leo.yan@linaro.org> - 2017-05-12 02:20 +0200
  Re: [PATCH v9 7/9] coresight: add support for CPU debug module Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2017-05-11 19:50 +0200

csiph-web