Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing throttle and yielded

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing throttle and yielded
Date	2017-05-11 22:00 +0200
Message-ID	<tG2pH-2dr-1@gated-at.bofh.it> (permalink)
References	<tFAjM-1pF-3@gated-at.bofh.it> <tFZ8v-dN-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 11, 2017 at 03:01:16PM +0100, Juri Lelli wrote:

> > -	if (dl_se->dl_yielded)
> > -		dl_se->dl_yielded = 0;
> > -	if (dl_se->dl_throttled)
> > -		dl_se->dl_throttled = 0;
> > +	dl_se->dl_yielded = 0;
> > +	dl_se->dl_throttled = 0;
> >  }
> 
> Looks good to me.
> 
> Peter, any particular reason why you wanted to first check the values?

No idea, could be general paranoia on unconditional writes or something.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH] sched/deadline: Remove if statement before clearing  throttle and yielded Steven Rostedt <rostedt@goodmis.org> - 2017-05-10 16:00 +0200
  Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing  throttle and yielded Juri Lelli <juri.lelli@arm.com> - 2017-05-11 18:30 +0200
    Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing  throttle and yielded Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-05-11 19:40 +0200
    Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing  throttle and yielded Peter Zijlstra <peterz@infradead.org> - 2017-05-11 22:00 +0200

csiph-web