Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640003
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Lockdep splat involving all_q_mutex |
| Date | 2017-05-11 22:30 +0200 |
| Message-ID | <tG2SJ-2Ew-9@gated-at.bofh.it> (permalink) |
| References | <tFIqZ-6rQ-1@gated-at.bofh.it> <tFMuB-wQ-1@gated-at.bofh.it> <tFMNX-SE-5@gated-at.bofh.it> <tG2J4-2Bd-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, May 11, 2017 at 02:12:39PM -0600, Jens Axboe wrote:
> On 05/10/2017 09:13 PM, Paul E. McKenney wrote:
> > On Wed, May 10, 2017 at 08:55:54PM -0600, Jens Axboe wrote:
> >> On 05/10/2017 04:34 PM, Paul E. McKenney wrote:
> >>> Hello!
> >>>
> >>> I got the lockdep splat shown below during some rcutorture testing (which
> >>> does CPU hotplug operations) on mainline at commit dc9edaab90de ("Merge
> >>> tag 'acpi-extra-4.12-rc1' of git://git.kernel.org/.../rafael/linux-pm").
> >>> My kneejerk reaction was just to reverse the "mutex_lock(&all_q_mutex);"
> >>> and "get_online_cpus();" in blk_mq_init_allocated_queue(), but then
> >>> I noticed that commit eabe06595d62 ("block/mq: Cure cpu hotplug lock
> >>> inversion") just got done moving these two statements in the other
> >>> direction.
> >>
> >> The problem is that that patch got merged too early, as it only
> >> fixes a lockdep splat with the cpu hotplug rework. Fix is coming Linus'
> >> way, it's in my for-linus tree.
> >
> > Thank you for the update, looking forward to the fix.
>
> It's upstream now.
Thank you, Jens! I will test it this evening, Pacific Time.
Thanx, Paul
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Lockdep splat involving all_q_mutex "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-11 00:40 +0200
Re: Lockdep splat involving all_q_mutex Jens Axboe <axboe@kernel.dk> - 2017-05-11 05:00 +0200
Re: Lockdep splat involving all_q_mutex "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-11 05:20 +0200
Re: Lockdep splat involving all_q_mutex Jens Axboe <axboe@kernel.dk> - 2017-05-11 22:20 +0200
Re: Lockdep splat involving all_q_mutex "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-11 22:30 +0200
Re: Lockdep splat involving all_q_mutex "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-12 07:10 +0200
csiph-web