Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639917

Re: [PATCH] ARM: remove duplicate 'const' annotations'

Show all headers | View raw

On 05/11/2017 04:50 AM, Arnd Bergmann wrote:
> gcc-7 warns about some declarations that are more 'const' than necessary:
> 
> arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>  static const struct of_device_id const ramc_ids[] __initconst = {
> arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>  static const struct of_device_id const bcm_kona_smc_ids[] __initconst = {
> arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>  static const struct of_device_id const timer_of_match[] __initconst = {
> arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>  static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = {
> arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
>  static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = {
> 
> The ones in arch/arm were apparently all introduced accidentally by one
> commit that correctly marked a lot of variables as __initconst.
> 
> Cc: Nicolas Pitre <nico@linaro.org>
> Fixes: 19c233b79d1a ("ARM: appropriate __init annotation for const data")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

>  arch/arm/mach-bcm/bcm_kona_smc.c | 2 +-

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: remove duplicate 'const' annotations' Arnd Bergmann <arnd@arndb.de> - 2017-05-11 14:00 +0200
  Re: [PATCH] ARM: remove duplicate 'const' annotations' Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-05-11 17:10 +0200
  Re: [PATCH] ARM: remove duplicate 'const' annotations' Florian Fainelli <f.fainelli@gmail.com> - 2017-05-11 19:30 +0200
  Re: [PATCH] ARM: remove duplicate 'const' annotations' Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-12 06:30 +0200
  Re: [PATCH] ARM: remove duplicate 'const' annotations' khalasa@piap.pl (Krzysztof Hałasa) - 2017-05-12 06:50 +0200
  Re: [PATCH] ARM: remove duplicate 'const' annotations' Arnd Bergmann <arnd@arndb.de> - 2017-05-19 10:20 +0200

csiph-web