Re: [PATCH v4 06/27] fs: check for writeback errors after syncing out buffers in generic_file_fsync

From	Matthew Wilcox <willy@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 06/27] fs: check for writeback errors after syncing out buffers in generic_file_fsync
Date	2017-05-10 15:00 +0200
Message-ID	<tFznH-QK-7@gated-at.bofh.it> (permalink)
References	<tFfIm-3IS-7@gated-at.bofh.it> <tFfIm-3IS-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 09, 2017 at 11:49:09AM -0400, Jeff Layton wrote:
> ext2 currently does a test+clear of the AS_EIO flag, which is
> is problematic for some coming changes.
> 
> What we really need to do instead is call filemap_check_errors
> in __generic_file_fsync after syncing out the buffers. That
> will be sufficient for this case, and help other callers detect
> these errors properly as well.
> 
> With that, we don't need to twiddle it in ext2.
> 
> Suggested-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Jan Kara <jack@suse.cz>

Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 06/27] fs: check for writeback errors after syncing out buffers in generic_file_fsync Jeff Layton <jlayton@redhat.com> - 2017-05-09 18:00 +0200
  Re: [PATCH v4 06/27] fs: check for writeback errors after syncing  out buffers in generic_file_fsync Matthew Wilcox <willy@infradead.org> - 2017-05-10 15:00 +0200

csiph-web