Re: [PATCH v4 1/3] KASLR: Parse all memmap entries in cmdline

From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/3] KASLR: Parse all memmap entries in cmdline
Date	2017-05-10 15:20 +0200
Message-ID	<tFzH3-1cQ-1@gated-at.bofh.it> (permalink)
References	<tF6lH-5Sx-3@gated-at.bofh.it> <tF6lH-5Sx-1@gated-at.bofh.it> <tFz4m-Kr-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/10/17 at 02:29pm, Thomas Gleixner wrote:
> On Tue, 9 May 2017, Baoquan He wrote:
> 
> > In commit:
> > 
> >   f28442497b5c ("x86/boot: Fix KASLR and memmap= collision")
> > 
> > ... the memmap= option is parsed so that KASLR can avoid those reserved
> > regions. It uses cmdline_find_option() to get the value if memmap=
> > is specified, however the problem is that cmdline_find_option() can only
> > find the last entry if multiple memmap entries are provided. This
> > is not correct.
> > 
> > In this patch, the whole cmdline will be scanned to search each
> 
> Can you please finally stop using this 'This patch does foo', 'In this
> patch' phrases. They are bogus. We already know that this is a patch
> otherwise you wouldn't have sent it.
> 
> See Documentation/process/SubmittingPatches.txt
> 
> Aside of that can you please use properly written out words instead of
> using random abbreviations in the changelog, e.g. command line instead of
> cmdline?
> 
> > memmap, all of them will be parsed and handled.
> 
> A proper example would be:
> 
>    Address this by checking each command line token for a "memmap=" match
>    and parse each instance instead of using cmdline_find_option().

Sorry for those mistakes. Will change accordingly when repost.

Thanks
Baoquan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 1/3] KASLR: Parse all memmap entries in cmdline Baoquan He <bhe@redhat.com> - 2017-05-09 08:00 +0200
  Re: [PATCH v4 1/3] KASLR: Parse all memmap entries in cmdline Thomas Gleixner <tglx@linutronix.de> - 2017-05-10 14:40 +0200
    Re: [PATCH v4 1/3] KASLR: Parse all memmap entries in cmdline Baoquan He <bhe@redhat.com> - 2017-05-10 15:20 +0200

csiph-web