Re: [PATCH v4 11/27] fuse: set mapping error in writepage_locked when it fails

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 11/27] fuse: set mapping error in writepage_locked when it fails
Date	2017-05-10 13:20 +0200
Message-ID	<tFxOV-8sH-9@gated-at.bofh.it> (permalink)
References	<tFfIm-3IS-7@gated-at.bofh.it> <tFfIo-3IS-71@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 09-05-17 11:49:14, Jeff Layton wrote:
> This ensures that we see errors on fsync when writeback fails.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/fuse/file.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index ec238fb5a584..07d0efcb050c 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page)
>  err_free:
>  	fuse_request_free(req);
>  err:
> +	mapping_set_error(page->mapping, error);
>  	end_page_writeback(page);
>  	return error;
>  }
> -- 
> 2.9.3
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 11/27] fuse: set mapping error in writepage_locked when it fails Jeff Layton <jlayton@redhat.com> - 2017-05-09 18:00 +0200
  Re: [PATCH v4 11/27] fuse: set mapping error in writepage_locked  when it fails Jan Kara <jack@suse.cz> - 2017-05-10 13:20 +0200

csiph-web