Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638633

Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for Mediatek PCIe

Show all headers | View raw

On Wed, May 10, 2017 at 4:07 AM, Ryder Lee <ryder.lee@mediatek.com> wrote:

> +- ranges:
> +  - The first three entries are expected to translate the addresses for the root
> +    port registers, which are referenced by the assigned-addresses property of
> +    the root port nodes (see below).

I don't understand this part. Why do you need a static translation for these?
Shouldn't they just be listed in the 'reg' property of the parent node now that
you have the clk/reset/phy properties in the parent as well?

> +Required properties:
> +- device_type: Must be "pci"
> +- assigned-addresses: Address and size of the port configuration registers
> +- reg: Only the first four bytes are used to refer to the correct bus number
> +  and device number.
> +- #address-cells: Must be 3
> +- #size-cells: Must be 2
> +- #interrupt-cells: Must be 1
> +- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties
> +  Please refer to the standard PCI bus binding document for a more detailed
> +  explanation.

Child nodes do not normally have interrupt-map properties. Isn't this
already covered by the interrupt-map in the parent?

      Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/2] dt-bindings: pcie: Add documentation for Mediatek PCIe Ryder Lee <ryder.lee@mediatek.com> - 2017-05-10 04:10 +0200
  Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for Mediatek PCIe Arnd Bergmann <arnd@arndb.de> - 2017-05-10 10:10 +0200
    Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for  Mediatek PCIe Ryder Lee <ryder.lee@mediatek.com> - 2017-05-10 11:40 +0200
      Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for Mediatek PCIe Arnd Bergmann <arnd@arndb.de> - 2017-05-10 12:10 +0200
        Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for  Mediatek PCIe Ryder Lee <ryder.lee@mediatek.com> - 2017-05-11 04:50 +0200
          Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for Mediatek PCIe Arnd Bergmann <arnd@arndb.de> - 2017-05-11 09:20 +0200
            Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for  Mediatek PCIe Ryder Lee <ryder.lee@mediatek.com> - 2017-05-11 11:10 +0200
              Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for  Mediatek PCIe Ryder Lee <ryder.lee@mediatek.com> - 2017-05-11 14:20 +0200
  Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for Mediatek  PCIe Matthias Brugger <matthias.bgg@gmail.com> - 2017-05-10 10:10 +0200
    Re: [PATCH v3 2/2] dt-bindings: pcie: Add documentation for  Mediatek PCIe Ryder Lee <ryder.lee@mediatek.com> - 2017-05-10 11:40 +0200

csiph-web