Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1638568

Re: [PATCH] x86/power/64: Use char arrays for asm function names

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/power/64: Use char arrays for asm function names
Date 2017-05-10 07:50 +0200
Message-ID <tFsFA-5aG-3@gated-at.bofh.it> (permalink)
References <tFkym-7gI-9@gated-at.bofh.it> <tFkRI-7nu-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Rafael J. Wysocki <rjw@rjwysocki.net> wrote:

> On Tuesday, May 09, 2017 02:00:51 PM Kees Cook wrote:
> > This switches the hibernate_64.S function names into character arrays
> > to match other areas of the kernel where this is done (e.g., linker
> > scripts). Specifically this fixes a compile-time error noticed by the
> > future CONFIG_FORTIFY_SOURCE routines that complained about PAGE_SIZE
> > being copied out of the "single byte" core_restore_code variable.
> > 
> > Additionally drops the "acpi_save_state_mem" exern which does not
> > appear to be used anywhere else in the kernel.
> > 
> > Cc: Daniel Micay <danielmicay@gmail.com>
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Or I can queue this up if that's preferred.

LGTM too!

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] x86/power/64: Use char arrays for asm function names Kees Cook <keescook@chromium.org> - 2017-05-09 23:10 +0200
  Re: [PATCH] x86/power/64: Use char arrays for asm function names "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-05-09 23:30 +0200
    Re: [PATCH] x86/power/64: Use char arrays for asm function names Ingo Molnar <mingo@kernel.org> - 2017-05-10 07:50 +0200
  Re: [PATCH] x86/power/64: Use char arrays for asm function names Pavel Machek <pavel@ucw.cz> - 2017-05-11 22:20 +0200

csiph-web