Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638242

[PATCH 1/7] staging: typec: tcpci: declare private structure as static

Show all headers | View raw

From: Olivier Leveque <o_leveque@orange.fr>

This fixes a sparse warning regarding an undeclared symbol. Since the
structure tcpci_tcpc_config is private to tcpci.c, it should be declared as
static.

Signed-off-by: Olivier Leveque <o_leveque@orange.fr>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/staging/typec/tcpci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 5e5be74c7850..df72d8b01e73 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
 	.max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
 };
 
-const struct tcpc_config tcpci_tcpc_config = {
+static const struct tcpc_config tcpci_tcpc_config = {
 	.type = TYPEC_PORT_DFP,
 	.default_role = TYPEC_SINK,
 };
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/7] staging: typec: tcpci: declare private structure as static Guenter Roeck <linux@roeck-us.net> - 2017-05-09 18:10 +0200
  [PATCH 2/7] staging: typec: fusb302: Fix module autoload Guenter Roeck <linux@roeck-us.net> - 2017-05-09 18:10 +0200
  [PATCH 4/7] staging: typec: tcpm: Drop duplicate PD messages Guenter Roeck <linux@roeck-us.net> - 2017-05-09 18:10 +0200
  [PATCH 3/7] staging: typec: fusb302: Fix chip->vbus_present init value Guenter Roeck <linux@roeck-us.net> - 2017-05-09 18:10 +0200
  [PATCH 5/7] staging: typec: tcpm: Set correct flags in PD request messages Guenter Roeck <linux@roeck-us.net> - 2017-05-09 18:10 +0200
  Re: [PATCH 1/7] staging: typec: tcpci: declare private structure as  static Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-09 19:50 +0200
    Re: [PATCH 1/7] staging: typec: tcpci: declare private structure as  static Guenter Roeck <linux@roeck-us.net> - 2017-05-09 23:20 +0200

csiph-web