Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638245

Re: [PATCH v2 0/3] nVMX: Emulated Page Modification Logging for Nested Virtualization

Show all headers | View raw

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 05/05/2017 21:25, Bandan Das wrote:
>> v2:
>> 2/3: Clear out all bits except bit 12
>> 3/3: Slightly modify an existing comment, honor L0's
>> PML setting when clearing it for L1
>> 
>> v1:
>> http://www.spinics.net/lists/kvm/msg149247.html
>> 
>> These patches implement PML on top of EPT A/D emulation
>> (ae1e2d1082ae).
>> 
>> When dirty bit is being set, we write the gpa to the
>> buffer provided by L1. If the index overflows, we just
>> change the exit reason before running L1.
>
> I tested this with api/dirty-log-perf, and nested PML is more than 3
> times faster than pml=0.  I want to do a few more tests because I don't
> see any PML full exits in the L1 trace, but it seems to be a nice
> improvement!

Thanks for testing! Regarding the PML full exits, I did notice their
absence. I induced it artifically in my testing with a lower index
and it seemed to work fine.

> Paolo
>
>> Bandan Das (3):
>>   kvm: x86: Add a hook for arch specific dirty logging emulation
>>   nVMX: Implement emulated Page Modification Logging
>>   nVMX: Advertise PML to L1 hypervisor
>> 
>>  arch/x86/include/asm/kvm_host.h |  2 +
>>  arch/x86/kvm/mmu.c              | 15 +++++++
>>  arch/x86/kvm/mmu.h              |  1 +
>>  arch/x86/kvm/paging_tmpl.h      |  4 ++
>>  arch/x86/kvm/vmx.c              | 97 ++++++++++++++++++++++++++++++++++++++---
>>  5 files changed, 112 insertions(+), 7 deletions(-)
>> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] nVMX: Emulated Page Modification Logging for Nested Virtualization Bandan Das <bsd@redhat.com> - 2017-05-05 21:30 +0200
  [PATCH v2 1/3] kvm: x86: Add a hook for arch specific dirty logging emulation Bandan Das <bsd@redhat.com> - 2017-05-05 21:30 +0200
    Re: [PATCH v2 1/3] kvm: x86: Add a hook for arch specific dirty  logging emulation "Huang, Kai" <kai.huang@linux.intel.com> - 2017-05-10 13:00 +0200
      Re: [PATCH v2 1/3] kvm: x86: Add a hook for arch specific dirty logging emulation Bandan Das <bsd@redhat.com> - 2017-05-10 18:00 +0200
        Re: [PATCH v2 1/3] kvm: x86: Add a hook for arch specific dirty  logging emulation "Huang, Kai" <kai.huang@linux.intel.com> - 2017-05-11 01:30 +0200
          Re: [PATCH v2 1/3] kvm: x86: Add a hook for arch specific dirty logging emulation Bandan Das <bsd@redhat.com> - 2017-05-11 20:40 +0200
  Re: [PATCH v2 0/3] nVMX: Emulated Page Modification Logging for  Nested Virtualization Paolo Bonzini <pbonzini@redhat.com> - 2017-05-09 17:30 +0200
    Re: [PATCH v2 0/3] nVMX: Emulated Page Modification Logging for Nested Virtualization Bandan Das <bsd@redhat.com> - 2017-05-09 18:10 +0200
      Re: [PATCH v2 0/3] nVMX: Emulated Page Modification Logging for  Nested Virtualization Paolo Bonzini <pbonzini@redhat.com> - 2017-05-11 07:10 +0200

csiph-web