Re: [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver
Date	2017-05-09 16:40 +0200
Message-ID	<tFesV-2Ya-3@gated-at.bofh.it> (permalink)
References	<tEWZ3-8eF-11@gated-at.bofh.it> <tEY4O-I2-21@gated-at.bofh.it> <tF786-6qs-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 09, 2017 at 08:42:21AM +0200, Hans de Goede wrote:
> On 08-05-17 23:04, Darren Hart wrote:
> > On Mon, May 08, 2017 at 09:56:31PM +0200, Hans de Goede wrote:

> > > +	peaq_poll_dev->input->name = "PEAQ WMI hotkeys";
> > 
> > Are there additional keys/buttons?
> 
> Not through the WMI interface on this model, I decided on the
> "PEAQ WMI hotkeys" name rather then say "PEAQ Dolby button"
> as future proofing (this gets exported to userspace so
> we should not change it in the future) in case this driver
> ends up delivering events for more special buttons on
> PEAQ devices.
> 
> As for all the other remarks from both you and Dmitry I agree
> with all of them and I will send a v2 addressing them all.
> 

Sounds good, thanks Hans.

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver Hans de Goede <hdegoede@redhat.com> - 2017-05-08 22:00 +0200
  Re: [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver Darren Hart <dvhart@infradead.org> - 2017-05-08 23:10 +0200
    Re: [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-08 23:40 +0200
    Re: [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver Hans de Goede <hdegoede@redhat.com> - 2017-05-09 08:50 +0200
      Re: [PATCH] platform/x86: peaq-wmi: Add new peaq-wmi driver Darren Hart <dvhart@infradead.org> - 2017-05-09 16:40 +0200

csiph-web