Re: [PATCH BUGFIX] block, bfq: use pointer entity->sched_data only if set

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH BUGFIX] block, bfq: use pointer entity->sched_data only if set
Date	Tue, 09 May 2017 17:00:03 +0200
Message-ID	<tFeMi-37Z-13@gated-at.bofh.it> (permalink)
References	<tF9MC-8jT-9@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=shnxOJnfIVJHuv+vbk5e2s1TJtiB7s/PuvuCfdcDXh8=; b=CsNLhBbeHT7WimKCngNcb+zk/P4P0Q8UaayvO0S1MkFC5qmT+hAOIO12KW5MctEjlq +zUwZtS8ZgbXpDkBwzSo0WJxH7F70dh82njw9next9vT29Kf+hukrm008W2/tsOrR3jr IsVvUGJo6C8mc1TgSgVEl/baxnjKreZoc4RdJ2ZXYSn9NNVlX/EVhJaFdRaEye5BMsOM RKXNHiRajiOZMGhJijJgwdvNKBqDejBy0vmG+ir3KLM+9L/XeRe87IUlJTe74JZEuhIR Zj879x8/4IsMiaFEN/0zqDIa1obf4cIzoeTYmKjsCLef6p2nXHjT9byR1rtuJHTyeEiQ liTg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=shnxOJnfIVJHuv+vbk5e2s1TJtiB7s/PuvuCfdcDXh8=; b=Y/p0Cphaa1CIVkP4Cv7P3kMNX+V71CQNec9CmiNseIcJRxNkc5FWIocb6RVaTjVl2q zJ4ltLkLlGRLRRi0nvzGCLmu/kEIyvZ9xQTZWQ/1XQ0ug5un1Zrk3NJJpq/EAvkn7Zry IsmxAnmGY1cTrZGB/1HGxMIQ6FynPDPUNb5pgxjRl8PIMUG6A0GVgTkbBCUlQSUWGHnT To3HuNtu7+fwxiuZHPGIQjOhFP1G0nGUX02XMhghfZ/WUrImzW+b5wHb+ffFSx36nMDq 4ZuziTwLqzGwbp57CPaCvJq5gdYXBFnFG5nJdUgkNcsZvPOatTrwL3NR09yVZMjEKEsz UNNA==
X-Gm-Message-State	AODbwcDRoPZeclOj96/eWVGNdp0QrsiUQZDVR/h4oONvD0bP6AU18Vkn pigEmBMuGOk3cw==
X-Received	by 10.84.231.130 with SMTP id g2mr800871plk.2.1494341636804; Tue, 09 May 2017 07:53:56 -0700 (PDT)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	10
Organization	linux.* mail to news gateway
X-Original-Cc	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org
X-Original-Date	Tue, 9 May 2017 08:53:52 -0600
X-Original-Message-ID	<884a6d3c-40aa-c2a6-9981-82d48148429b@kernel.dk>
X-Original-References	<20170509093727.2595-1-paolo.valente@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1638178

Show key headers only | View raw

On 05/09/2017 03:37 AM, Paolo Valente wrote:
> In the function __bfq_deactivate_entity, the pointer
> entity->sched_data could happen to be used before being properly
> initialized. This led to a NULL pointer dereference. This commit fixes
> this bug by just using this pointer only where it is safe to do so.

Added, thanks.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH BUGFIX] block, bfq: use pointer entity->sched_data only if set Paolo Valente <paolo.valente@linaro.org> - 2017-05-09 11:40 +0200
  Re: [PATCH BUGFIX] block, bfq: use pointer entity->sched_data only if  set Jens Axboe <axboe@kernel.dk> - 2017-05-09 17:00 +0200

csiph-web